Feat: Improved exception logging #351
Conversation
|
Warning Rate limit exceeded@aaronsteers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 40 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughWalkthroughThe changes involve enhancements to error handling across multiple files in the Airbyte codebase. Key modifications include the introduction of specific exception classes, refined error reporting mechanisms, and adjustments to how exceptions are raised and handled in various methods. These updates aim to provide clearer context and improve the robustness of error management within the framework. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Connector
participant Subprocess
participant ExceptionHandler
User->>Connector: Initiate check
Connector->>ExceptionHandler: Handle AirbyteConnectorFailedError
ExceptionHandler->>Connector: Raise error with original_exception
User->>Connector: Execute process
Connector->>Subprocess: Start subprocess
Subprocess->>Connector: Return exit code
Connector->>ExceptionHandler: Handle AirbyteSubprocessFailedError
ExceptionHandler->>Connector: Raise error with log_text and context
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Outside diff range, codebase verification and nitpick comments (1)
airbyte/_executors/base.py (1)
45-48: Nice addition ofBrokenPipeErrorhandling! 👍This change improves the robustness of the input pumping process. What do you think about adding a debug log here to track when this specific error occurs? It might help with troubleshooting in the future. Something like:
import logging logger = logging.getLogger(__name__) # ... except BrokenPipeError: logger.debug("BrokenPipeError occurred in _pump_input") exception_holder.set_exception(exc.AirbyteConnectorBrokenPipeError())WDYT?
Cherry-picked drive-by changes from #350.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation