-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Refactor: Rename module _future_cdk
to shared
#354
Conversation
WalkthroughWalkthroughThe changes involve a restructuring of import statements across multiple files in the Airbyte codebase. Specifically, imports for various classes such as Changes
Sequence Diagram(s)sequenceDiagram
participant A as User
participant B as Application
participant C as Shared Module
A->>B: Request data processing
B->>C: Import required components
C-->>B: Provide components
B-->>A: Return processed data
Would you like to make any adjustments to the wording or details in the summary or changes? Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (2)
Files skipped from review due to trivial changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
_future_cdk
to shared
_future_cdk
to shared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
airbyte/shared/sql_processor.py (1)
52-52
: Consider using absolute imports for consistency?I noticed that we're using a relative import for
StdOutStateWriter
. Given that other imports in this file use absolute paths, would it make sense to use an absolute import here as well for consistency? For example:from airbyte.shared.state_writers import StdOutStateWriterWhat do you think? This could help maintain a consistent import style throughout the file.
Summary by CodeRabbit
Refactor
_future_cdk
module to theshared
module for improved organization and clarity.shared
namespace.Bug Fixes
Tests