Skip to content

Commit

Permalink
add log if createNewAttemptNumber throws an exception (#6914)
Browse files Browse the repository at this point in the history
  • Loading branch information
colesnodgrass committed May 31, 2023
1 parent 0f0b75d commit 7a5b569
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ public JobCreationOutput createNewJob(final JobCreationInput input) {
return new JobCreationOutput(jobId);
}
} catch (final JsonValidationException | ConfigNotFoundException | IOException e) {
log.error("createNewJob for connection {} failed with exception: {}", input.getConnectionId(), e.getMessage(), e);
throw new RetryableException(e);
}
}
Expand Down Expand Up @@ -257,6 +258,7 @@ public AttemptNumberCreationOutput createNewAttemptNumber(final AttemptCreationI
LogClientSingleton.getInstance().setJobMdc(workerEnvironment, logConfigs, jobRoot);
return new AttemptNumberCreationOutput(persistedAttemptNumber);
} catch (final IOException e) {
log.error("createNewAttemptNumber for job {} failed with exception: {}", input.getJobId(), e.getMessage(), e);
throw new RetryableException(e);
}
}
Expand Down Expand Up @@ -353,6 +355,7 @@ public void attemptFailureWithAttemptNumber(final AttemptNumberFailureInput inpu
emitJobIdToReleaseStagesMetric(OssMetricsRegistry.ATTEMPT_FAILED_BY_RELEASE_STAGE, jobId);
trackFailures(failureSummary);
} catch (final IOException e) {
log.error("attemptFailureWithAttemptNumber for job {} failed with exception: {}", input.getJobId(), e.getMessage(), e);
throw new RetryableException(e);
}
}
Expand Down

0 comments on commit 7a5b569

Please sign in to comment.