fix: loosen frontend cron validation (#13792)

airbytehq · Sep 2, 2024 · 8ccc517 · 8ccc517
1 parent 47fa764
commit 8ccc517
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/airbyte-webapp/src/area/connection/utils/validateCronExpression.test.ts b/airbyte-webapp/src/area/connection/utils/validateCronExpression.test.ts
@@ -50,6 +50,9 @@ describe("validateCronExpression", () => {
     ${"0 0 9 * * ?"}                                         | ${true}  | ${undefined}
     ${"0 0 9 ? * 5"}                                         | ${true}  | ${undefined}
     ${"0 1 0 * * ?"}                                         | ${true}  | ${undefined}
+    ${"* * * 1 * ?"}                                         | ${true}  | ${undefined}
+    ${"* * * 10 * ?"}                                        | ${true}  | ${undefined}
+    ${"* * * 31 * ?"}                                        | ${true}  | ${undefined}
     ${"0 15,45 7-17 ? * MON-FRI"}                            | ${true}  | ${undefined}
     ${"0 15 6 * * ?"}                                        | ${true}  | ${undefined}
     ${"0 30 1 * * ?"}                                        | ${true}  | ${undefined}
@@ -64,7 +67,7 @@ describe("validateCronExpression", () => {
     ${"* * * * * * *"}                                       | ${true}  | ${undefined}
     ${"wildly invalid"}                                      | ${false} | ${'Cron expression "wildly invalid" must contain at least 6 fields (2 fields found)'}
     ${"* * * * *"}                                           | ${false} | ${'Cron expression "* * * * *" must contain at least 6 fields (5 fields found)'}
-    ${"0 0 0 0 0 0"}                                         | ${false} | ${'"0" did not match regex at index 3'}
+    ${"0 0 0 0 0 0"}                                         | ${false} | ${'"0" did not match regex at index 4'}
     ${"* * * * * * ?"}                                       | ${false} | ${'"?" did not match regex at index 6'}
   `("'$expression' is valid: $isValid", ({ expression, isValid, message }) => {
     expect(validateCronExpression(expression).isValid).toEqual(isValid);

diff --git a/airbyte-webapp/src/area/connection/utils/validateCronExpression.ts b/airbyte-webapp/src/area/connection/utils/validateCronExpression.ts
@@ -2,7 +2,7 @@ const CRON_REGEX_MAP = [
   /^(([0-9]|,|-|\*|\/)+)$/, // seconds
   /^(([0-9]|,|-|\*|\/)+)$/, // minutes
   /^(([0-9]|,|-|\*|\/)+)$/, // hours
-  /^(([1-9]|,|-|\*|\/|\?|L|W)+)$/, // day of month
+  /^(([0-9]|,|-|\*|\/|\?|L|W)+)$/, // day of month
   /^(([1-9]|,|-|\*|\/|JAN|FEB|MAR|APR|JUN|JUL|AUG|SEP|OCT|NOV|DEC)+)$/, // month
   /^(([1-7]|,|-|\*|\/|\?|L|#|SUN|MON|TUE|WED|THU|FRI|SAT|SUN)+)$/, // day of week
   /^(([0-9]|,|-|\*|\/)+)/, // year