Skip to content

Commit

Permalink
chore: cleanup forgotten code for FF (#13763)
Browse files Browse the repository at this point in the history
  • Loading branch information
timroes committed Aug 29, 2024
1 parent 4dd60c5 commit fb8eaa0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { Text } from "components/ui/Text";

import { DestinationRead, SourceRead } from "core/api/types/AirbyteClient";
import { FeatureItem, useFeature } from "core/services/features";
import { useExperiment } from "hooks/services/Experiment";

import { SimplfiedSchemaChangesFormField } from "./SimplfiedSchemaChangesFormField";
import { SimplifiedBackfillFormField } from "./SimplifiedBackfillFormField";
Expand Down Expand Up @@ -39,7 +38,6 @@ export const SimplifiedConnectionsSettingsCard: React.FC<SimplifiedConnectionsSe
}) => {
const [isAdvancedOpen, setIsAdvancedOpen] = useState(false);
const canEditDataGeographies = useFeature(FeatureItem.AllowChangeDataGeographies);
const canBackfillNewColumns = useExperiment("platform.auto-backfill-on-new-columns", true);

return (
<Card title={title} className={styles.hideOverflow}>
Expand Down Expand Up @@ -92,7 +90,7 @@ export const SimplifiedConnectionsSettingsCard: React.FC<SimplifiedConnectionsSe
{!isCreating && <SimplifiedDestinationStreamPrefixNameFormField disabled={isDeprecated} />}
<SimplfiedSchemaChangesFormField isCreating={isCreating} disabled={isDeprecated} />
<SimplifiedSchemaChangeNotificationFormField disabled={isDeprecated} />
{canBackfillNewColumns && <SimplifiedBackfillFormField disabled={isDeprecated} />}
<SimplifiedBackfillFormField disabled={isDeprecated} />
</FlexContainer>
</Box>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export interface Experiments {
"connector.airbyteCloudIpAddresses": string;
"connector.suggestedSourceConnectors": string;
"connector.suggestedDestinationConnectors": string;
"platform.auto-backfill-on-new-columns": boolean;
"settings.breakingChangeNotifications": boolean;
"settings.showAdvancedSettings": boolean;
"upcomingFeaturesPage.url": string;
Expand Down
2 changes: 0 additions & 2 deletions tools/bin/acceptance-test-flags.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ flags:
serve: true
- name: refreshSchema.period.hours
serve: 0
- name: platform.auto-backfill-on-new-columns
serve: true
- name: platform.remove-large-sync-inputs
serve: true
- name: platform.use-workload-api
Expand Down

0 comments on commit fb8eaa0

Please sign in to comment.