-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The Java 19 toolchain doesn't like sneaky throws. Not entirely sure why. However, I think it's better practice to not use sneaky throws as it makes it clearer what is throw and where. Example error message when trying to compile the current codebase with Java 19: error: Error during the transformation of 'io.airbyte.validation.json.JsonSchemaValidatorTest'; post-compiler 'lombok.bytecode.SneakyThrowsRemover' caused an exception: java.lang.IllegalArgumentException: Unsupported class file major version 63 at org.objectweb.asm.ClassReader.<init>(ClassReader.java:199) at org.objectweb.asm.ClassReader.<init>(ClassReader.java:180) at org.objectweb.asm.ClassReader.<init>(ClassReader.java:166) at lombok.bytecode.AsmUtil.fixJSRInlining(AsmUtil.java:37) at lombok.bytecode.SneakyThrowsRemover.applyTransformations(SneakyThrowsRemover.java:46) at lombok.core.PostCompiler.applyTransformations(PostCompiler.java:44) at lombok.core.PostCompiler$1.close(PostCompiler.java:87) at jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeClass(ClassWriter.java:1508) at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.genCode(JavaCompiler.java:738)
- Loading branch information
Showing
3 changed files
with
13 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters