Skip to content

Commit

Permalink
relax constraint about parallel discovery speedup
Browse files Browse the repository at this point in the history
  • Loading branch information
sherifnada committed Feb 28, 2022
1 parent 0b584e6 commit 1a4126b
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def test_update_for_deleted_record(stream):
response = update_note(stream, created_note_id, headers)
assert response.status_code == 404, "Expected an update to a deleted note to return 404"


def test_deleted_record(stream):
headers = stream.authenticator.get_auth_header()
response = create_note(stream, headers)
Expand Down Expand Up @@ -141,7 +142,7 @@ def test_parallel_discover(input_sandbox_config):
parallel_schemas = sf.generate_schemas(stream_objects)
parallel_loading_time = (datetime.now() - start_time).total_seconds()

assert parallel_loading_time < consecutive_loading_time / 10, "parallel should be more than 10x faster"
assert parallel_loading_time < consecutive_loading_time / 5.0, "parallel should be more than 10x faster"
assert set(consecutive_schemas.keys()) == set(parallel_schemas.keys())
for stream_name, schema in consecutive_schemas.items():
assert schema == parallel_schemas[stream_name]

1 comment on commit 1a4126b

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube Report

SonarQube report for Airbyte Connectors Source Salesforce(#10516)

Measures

Name Value Name Value Name Value
Bugs 0 Coverage 88.1 Duplicated Lines (%) 0.0
Lines of Code 826 Duplicated Blocks 0 Security Rating A
Vulnerabilities 0 Lines to Cover 523 Quality Gate Status OK
Code Smells 0 Reliability Rating A Blocker Issues 0
Critical Issues 0 Major Issues 0 Minor Issues 0

Coverage (88.1%)

File Coverage File Coverage
source_salesforce/init.py 100.0 source_salesforce/api.py 90.7
source_salesforce/exceptions.py 100.0 source_salesforce/rate_limiting.py 86.4
source_salesforce/source.py 92.0 source_salesforce/streams.py 85.2
source_salesforce/utils.py 100.0

Please sign in to comment.