Upgrade plop in connector generators (#10578)

* Upgrade plop * Remove scaffolded code * Build fixes * Remove scaffolded code * Revert "Remove scaffolded code" This reverts commit 3911f52. * Revert "Remove scaffolded code" This reverts commit 549f790. * Remove .gitignore changes * Remove .gitignore changes * Update scaffold generated code * Replace titleCase with capitalCase (#10654) * Add capitalCase helper * Replace titleCase with capitalCase * Update generated scaffold files Co-authored-by: LiRen Tu <tuliren.git@outlook.com>
airbytehq · Feb 28, 2022 · 2855dfc · 2855dfc
1 parent 9e941f3
commit 2855dfc
Show file tree

Hide file tree

Showing 26 changed files with 2,765 additions and 1,663 deletions.
diff --git a/airbyte-integrations/connector-templates/destination-java/README.md.hbs b/airbyte-integrations/connector-templates/destination-java/README.md.hbs
@@ -1,6 +1,6 @@
-# Destination {{titleCase name}}
+# Destination {{capitalCase name}}
 
-This is the repository for the {{titleCase name}} destination connector in Java.
+This is the repository for the {{capitalCase name}} destination connector in Java.
 For information about how to use this connector within Airbyte, see [the User Documentation](https://docs.airbyte.io/integrations/destinations/{{dashCase name}}).
 
 ## Local development

diff --git a/airbyte-integrations/connector-templates/destination-java/definition.yaml.hbs b/airbyte-integrations/connector-templates/destination-java/definition.yaml.hbs
@@ -1,5 +1,5 @@
 - destinationDefinitionId: {{uuid}}
-  name: {{titleCase name}}
+  name: {{capitalCase name}}
   dockerRepository: airbyte/destination-{{dashCase name}}
   dockerImageTag: 0.1.0
   documentationUrl: https://docs.airbyte.io/integrations/destinations/{{dashCase name}}
diff --git a/airbyte-integrations/connector-templates/destination-java/doc.md.hbs b/airbyte-integrations/connector-templates/destination-java/doc.md.hbs
@@ -1,4 +1,4 @@
-# {{titleCase name}}
+# {{capitalCase name}}
 
 TODO: update this doc
 

diff --git a/airbyte-integrations/connector-templates/destination-python/README.md b/airbyte-integrations/connector-templates/destination-python/README.md
@@ -1,6 +1,6 @@
-# {{titleCase name}} Destination
+# {{capitalCase name}} Destination
 
-This is the repository for the {{titleCase name}} destination connector, written in Python.
+This is the repository for the {{capitalCase name}} destination connector, written in Python.
 For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/destinations/{{dashCase name}}).
 
 ## Local development

diff --git a/...egrations/connector-templates/destination-python/destination_{{snakeCase name}}/spec.json b/...egrations/connector-templates/destination-python/destination_{{snakeCase name}}/spec.json
@@ -8,7 +8,7 @@
   "supportsNormalization": false,
   "connectionSpecification": {
     "$schema": "http://json-schema.org/draft-07/schema#",
-    "title": "Destination {{titleCase name}}",
+    "title": "Destination {{capitalCase name}}",
     "type": "object",
     "required": ["TODO -- fix me!"],
     "additionalProperties": false,

diff --git a/airbyte-integrations/connector-templates/destination-python/setup.py b/airbyte-integrations/connector-templates/destination-python/setup.py
@@ -15,7 +15,7 @@
 
 setup(
     name="destination_{{snakeCase name}}",
-    description="Destination implementation for {{titleCase name}}.",
+    description="Destination implementation for {{capitalCase name}}.",
     author="Airbyte",
     author_email="contact@airbyte.io",
     packages=find_packages(),

diff --git a/airbyte-integrations/connector-templates/generator/Dockerfile b/airbyte-integrations/connector-templates/generator/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:14-alpine
+FROM node:16-alpine
 
 ARG UID
 ARG GID

diff --git a/airbyte-integrations/connector-templates/generator/build.gradle b/airbyte-integrations/connector-templates/generator/build.gradle
@@ -3,7 +3,7 @@ plugins {
     id "com.github.node-gradle.node" version "2.2.4"
 }
 
-def nodeVersion = System.getenv('NODE_VERSION') ?: '14.11.0'
+def nodeVersion = System.getenv('NODE_VERSION') ?: '16.13.0'
 
 node {
     download = true
@@ -14,9 +14,9 @@ assemble.dependsOn(npmInstall)
 
 task testScaffoldTemplates
 
-def addScaffoldTemplateTask(name, packageName,scaffoldParams=[]) {
+def addScaffoldTemplateTask(name, packageName, outputDirName, scaffoldParams=[]) {
     def taskName = "testScaffoldTemplate_${name}"
-    def outputDir = "airbyte-integrations/connectors/source-${packageName}"
+    def outputDir = "airbyte-integrations/connectors/${outputDirName}"
 
    def task = tasks.create(taskName) {
         inputs.files rootProject.fileTree("airbyte-integrations/connector-templates/")
@@ -40,9 +40,9 @@ def addScaffoldTemplateTask(name, packageName,scaffoldParams=[]) {
     testScaffoldTemplates.dependsOn task
 }
 
-addScaffoldTemplateTask('Python Source', 'scaffold-source-python')
-addScaffoldTemplateTask('Python HTTP API Source', 'scaffold-source-http')
-addScaffoldTemplateTask('Java JDBC Source', 'scaffold-java-jdbc')
-addScaffoldTemplateTask('Python Destination', 'scaffold-destination-python')
+addScaffoldTemplateTask('Python Source', 'scaffold-source-python', 'source-scaffold-source-python')
+addScaffoldTemplateTask('Python HTTP API Source', 'scaffold-source-http', 'source-scaffold-source-http')
+addScaffoldTemplateTask('Java JDBC Source', 'scaffold-java-jdbc', 'source-scaffold-java-jdbc')
+addScaffoldTemplateTask('Python Destination', 'scaffold-destination-python', 'destination-scaffold-destination-python')
 // TODO: enable Singer template testing
 //addScaffoldTask('source-python-singer', ['tap-exchangeratesapi'])