Skip to content

Commit

Permalink
🎉 Source Bing Ads - added high test_strictness_level (#22103)
Browse files Browse the repository at this point in the history
* added high test_strictness_level

* updated expected records

* added allowedHosts for bing ads

---------

Co-authored-by: Serhii Lazebnyi <53845333+lazebnyi@users.noreply.github.com>
  • Loading branch information
midavadim and lazebnyi authored Feb 6, 2023
1 parent f098287 commit 285661c
Show file tree
Hide file tree
Showing 3 changed files with 64 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,14 @@
icon: bingads.svg
sourceType: api
releaseStage: generally_available
allowedHosts:
hosts:
- bingads.microsoft.com
- login.microsoftonline.com
- login.live.com
- login.windows-ppe.net
- ads.microsoft.com
- api.ads.microsoft.com
- name: Braintree
sourceDefinitionId: 63cea06f-1c75-458d-88fe-ad48c7cb27fd
dockerRepository: airbyte/source-braintree
Expand Down
Original file line number Diff line number Diff line change
@@ -1,26 +1,41 @@
connector_image: airbyte/source-bing-ads:dev
tests:
test_strictness_level: high
acceptance_tests:
spec:
- spec_path: "source_bing_ads/spec.json"
connection:
- config_path: "secrets/config_old.json"
status: "succeed"
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
tests:
- spec_path: source_bing_ads/spec.json
discovery:
- config_path: "secrets/config.json"
tests:
- config_path: secrets/config.json
connection:
tests:
- config_path: secrets/config_old.json
status: succeed
- config_path: secrets/config.json
status: succeed
- config_path: integration_tests/invalid_config.json
status: failed
basic_read:
- config_path: "secrets/config.json"
timeout_seconds: 600
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: ["account_performance_report_hourly","ad_group_performance_report_hourly","ad_performance_report_hourly","campaign_performance_report_hourly","keyword_performance_report_hourly"]
# incremental test doesn"t work if a single stream has multiple states
#incremental:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
# future_state_path: "integration_tests/abnormal_state.json"
tests:
- config_path: secrets/config.json
expect_records:
path: "integration_tests/expected_records.txt"
extra_records: yes
empty_streams:
- name: account_performance_report_hourly
bypass_reason: "Hourly reports are disabled, because sync is too long"
- name: ad_group_performance_report_hourly
bypass_reason: "Hourly reports are disabled, because sync is too long"
- name: ad_performance_report_hourly
bypass_reason: "Hourly reports are disabled, because sync is too long"
- name: campaign_performance_report_hourly
bypass_reason: "Hourly reports are disabled, because sync is too long"
- name: keyword_performance_report_hourly
bypass_reason: "Hourly reports are disabled, because sync is too long"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
tests:
- config_path: secrets/config.json
configured_catalog_path: integration_tests/configured_catalog.json
incremental:
tests:
bypass_reason: "SAT doesn't support complex nested states used in incremental report streams"
Loading

0 comments on commit 285661c

Please sign in to comment.