Skip to content

Commit

Permalink
Destination e2e test: enable dedup (#38097)
Browse files Browse the repository at this point in the history
  • Loading branch information
edgao authored May 9, 2024
1 parent a42532a commit 4c7ebfa
Show file tree
Hide file tree
Showing 6 changed files with 963 additions and 1,640 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: unknown
connectorType: destination
definitionId: 2eb65e87-983a-4fd7-b3e3-9d9dc6eb8537
dockerImageTag: 0.3.5
dockerImageTag: 0.3.6
dockerRepository: airbyte/destination-e2e-test
githubIssueLabel: destination-e2e-test
icon: airbyte.svg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"supportsIncremental": true,
"supportsNormalization": false,
"supportsDBT": false,
"supported_destination_sync_modes": ["overwrite", "append"],
"supported_destination_sync_modes": ["overwrite", "append", "append_dedup"],
"protocol_version": "0.2.1",
"connectionSpecification": {
"$schema": "http://json-schema.org/draft-07/schema#",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

public class TestingSilentDestinationAcceptanceTest extends DestinationAcceptanceTest {

Expand Down Expand Up @@ -60,8 +62,18 @@ protected void assertSameMessages(final List<AirbyteMessage> expected,
}

@Override
public void testSyncNotFailsWithNewFields() {
// Skip because `retrieveRecords` returns an empty list at all times.
// Skip because `retrieveRecords` returns an empty list at all times.
@Disabled
@Test
public void testSyncNotFailsWithNewFields() {}

@Override
// This test assumes that dedup support means normalization support.
// Override it to do nothing.
@Disabled
@Test
public void testIncrementalDedupeSync() throws Exception {
super.testIncrementalDedupeSync();
}

}
Binary file modified dagger_engine_logs.tgz
Binary file not shown.
Loading

0 comments on commit 4c7ebfa

Please sign in to comment.