fix: Address review issues

- Fixed Dockefile and changelog version to 0.1.0 - Added order property on spec.yaml - AdditionalProperties to the proper objects in schema definitions and made all fields nullable
airbytehq · Jun 12, 2023 · 57f39e9 · 57f39e9
1 parent 2f6c936
commit 57f39e9
Show file tree

Hide file tree

Showing 13 changed files with 348 additions and 296 deletions.
diff --git a/airbyte-integrations/connectors/source-kyve/Dockerfile b/airbyte-integrations/connectors/source-kyve/Dockerfile
@@ -34,5 +34,5 @@ COPY source_kyve ./source_kyve
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.0.1
+LABEL io.airbyte.version=0.1.0
 LABEL io.airbyte.name=airbyte/source-kyve
diff --git a/airbyte-integrations/connectors/source-kyve/source_kyve/schemas/bitcoin/block.json b/airbyte-integrations/connectors/source-kyve/source_kyve/schemas/bitcoin/block.json
@@ -1,60 +1,61 @@
 {
   "$schema" : "http://json-schema.org/draft-04/schema#",
   "type" : "object",
+  "additionalProperties": true,
   "properties" : {
     "hash" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "height" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "version" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "versionHex" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "merkleroot" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "time" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "mediantime" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "nonce" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "bits" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "difficulty" : {
-      "type" : "number"
+      "type" : ["null", "number"]
     },
     "chainwork" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "nTx" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "previousblockhash" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "nextblockhash" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "strippedsize" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "size" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "weight" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "tx" : {
-      "type" : "array",
+      "type" : ["null", "array"],
       "items" : {
         "$ref" : "bitcoin/transaction.json"
       }

diff --git a/airbyte-integrations/connectors/source-kyve/source_kyve/schemas/bitcoin/transaction.json b/airbyte-integrations/connectors/source-kyve/source_kyve/schemas/bitcoin/transaction.json
@@ -1,47 +1,48 @@
 {
   "$schema" : "http://json-schema.org/draft-04/schema#",
   "type" : "object",
+  "additionalProperties": true,
   "properties" : {
     "txid" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "hash" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "version" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "size" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "vsize" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "weight" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "locktime" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "vin" : {
-      "type" : "array",
+      "type" : ["null", "array"],
       "items" : {
-        "type" : "object",
+        "type" : ["null", "object"],
         "properties" : {
           "txid" : {
-            "type" : "string"
+            "type" : ["null", "string"]
           },
           "vout" : {
-            "type" : "integer"
+            "type" : ["null", "integer"]
           },
           "scriptSig" : {
-            "type" : "object",
+            "type" : ["null", "object"],
             "properties" : {
               "asm" : {
-                "type" : "string"
+                "type" : ["null", "string"]
               },
               "hex" : {
-                "type" : "string"
+                "type" : ["null", "string"]
               }
             },
             "required" : [
@@ -50,7 +51,7 @@
             ]
           },
           "sequence" : {
-            "type" : "integer"
+            "type" : ["null", "integer"]
           }
         },
         "required" : [
@@ -62,33 +63,33 @@
       }
     },
     "vout" : {
-      "type" : "array",
+      "type" : ["null", "array"],
       "items" : {
-        "type" : "object",
+        "type" : ["null", "object"],
         "properties" : {
           "value" : {
-            "type" : "number"
+            "type" : ["null", "number"]
           },
           "n" : {
-            "type" : "integer"
+            "type" : ["null", "integer"]
           },
           "scriptPubKey" : {
-            "type" : "object",
+            "type" : ["null", "object"],
             "properties" : {
               "asm" : {
-                "type" : "string"
+                "type" : ["null", "string"]
               },
               "desc" : {
-                "type" : "string"
+                "type" : ["null", "string"]
               },
               "hex" : {
-                "type" : "string"
+                "type" : ["null", "string"]
               },
               "address" : {
-                "type" : "string"
+                "type" : ["null", "string"]
               },
               "type" : {
-                "type" : "string"
+                "type" : ["null", "string"]
               }
             },
             "required" : [
@@ -108,10 +109,10 @@
       }
     },
     "fee" : {
-      "type" : "number"
+      "type" : ["null", "number"]
     },
     "hex" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     }
   },
   "required" : [

diff --git a/airbyte-integrations/connectors/source-kyve/source_kyve/schemas/celo/block.json b/airbyte-integrations/connectors/source-kyve/source_kyve/schemas/celo/block.json
@@ -1,33 +1,34 @@
 {
   "$schema" : "http://json-schema.org/draft-04/schema#",
   "type" : "object",
+  "additionalProperties": true,
   "properties" : {
     "hash" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "parentHash" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "number" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "timestamp" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "nonce" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "difficulty" : {
-      "type" : "integer"
+      "type" : ["null", "integer"]
     },
     "gasLimit" : {
-      "type" : "object",
+      "type" : ["null", "object"],
       "properties" : {
         "type" : {
-          "type" : "string"
+          "type" : ["null", "string"]
         },
         "hex" : {
-          "type" : "string"
+          "type" : ["null", "string"]
         }
       },
       "required" : [
@@ -36,13 +37,13 @@
       ]
     },
     "gasUsed" : {
-      "type" : "object",
+      "type" : ["null", "object"],
       "properties" : {
         "type" : {
-          "type" : "string"
+          "type" : ["null", "string"]
         },
         "hex" : {
-          "type" : "string"
+          "type" : ["null", "string"]
         }
       },
       "required" : [
@@ -51,10 +52,10 @@
       ]
     },
     "miner" : {
-      "type" : "string"
+      "type" : ["null", "string"]
     },
     "transactions" : {
-      "type" : "array",
+      "type" : ["null", "array"],
       "items" : {
         "$ref" : "celo/transaction.json"
       }