delete_public_access_block for bucket if public (#25663)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
airbytehq · Apr 28, 2023 · 67f047c · 67f047c
1 parent c6b8181
commit 67f047c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/airbyte-integrations/connectors/source-s3/integration_tests/integration_test.py b/airbyte-integrations/connectors/source-s3/integration_tests/integration_test.py
@@ -70,8 +70,12 @@ def cloud_files(self, cloud_bucket_name: str, credentials: Mapping, files_to_upl
         try:
             self.s3_client.head_bucket(Bucket=bucket_name)
         except ClientError:
-            acl = "private" if private else "public-read"
-            self.s3_client.create_bucket(ACL=acl, Bucket=bucket_name, CreateBucketConfiguration=location)
+            if private:
+                self.s3_client.create_bucket(Bucket=bucket_name, CreateBucketConfiguration=location)
+            else:
+                self.s3_client.create_bucket(Bucket=bucket_name, CreateBucketConfiguration=location, ObjectOwnership='ObjectWriter')
+                self.s3_client.delete_public_access_block(Bucket=bucket_name)
+                self.s3_client.put_bucket_acl(Bucket=bucket_name, ACL='public-read')
 
         # wait here until the bucket is ready
         ready = False