[airbyte-cdk] Update HttpClient to return correct error message in ca…

…se of FAIL/IGNORE (#42512)
airbytehq · Jul 26, 2024 · 9537394 · 9537394
1 parent 26e4905
commit 9537394
Show file tree

Hide file tree

Showing 3 changed files with 94 additions and 96 deletions.
diff --git a/airbyte-cdk/python/airbyte_cdk/sources/streams/http/http_client.py b/airbyte-cdk/python/airbyte_cdk/sources/streams/http/http_client.py
@@ -292,7 +292,7 @@ def _send(
             print(f"{message}\n", end="", flush=True)
 
         if error_resolution.response_action == ResponseAction.FAIL:
-            if response:
+            if response is not None:
                 error_message = f"'{request.method}' request to '{request.url}' failed with status code '{response.status_code}' and error message '{self._error_message_parser.parse_response_error_message(response)}'"
             else:
                 error_message = f"'{request.method}' request to '{request.url}' failed with exception: '{exc}'"
@@ -304,7 +304,7 @@ def _send(
             )
 
         elif error_resolution.response_action == ResponseAction.IGNORE:
-            if response:
+            if response is not None:
                 log_message = (
                     f"Ignoring response for '{request.method}' request to '{request.url}' with response code '{response.status_code}'"
                 )