Skip to content

Commit

Permalink
🐛Source Close.com: Fix Email Activities Stream Pagination (#31534)
Browse files Browse the repository at this point in the history 
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
  • Loading branch information
@topefolorunso @marcosmarxm
3 people authored Nov 10, 2023
1 parent 633cdd1 commit a7f6928
Show file tree
Hide file tree
Showing 19 changed files with 246 additions and 15 deletions.
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-close-com/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.4.2
LABEL io.airbyte.version=0.4.3
LABEL io.airbyte.name=airbyte/source-close-com
2 changes: 0 additions & 2 deletions airbyte-integrations/connectors/source-close-com/acceptance-test-config.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ acceptance_tests:
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
expect_records:
path: "integration_tests/expected_records.jsonl"
empty_streams:
- name: missed_call_tasks
bypass_reason: "unable to populate"
Expand Down
51 changes: 42 additions & 9 deletions airbyte-integrations/connectors/source-close-com/integration_tests/expected_records.jsonl
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-close-com/metadata.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: dfffecb7-9a13-43e9-acdc-b92af7997ca9
dockerImageTag: 0.4.2
dockerImageTag: 0.4.3
dockerRepository: airbyte/source-close-com
documentationUrl: https://docs.airbyte.com/integrations/sources/close-com
githubIssueLabel: source-close-com
Expand Down
5 changes: 3 additions & 2 deletions airbyte-integrations/connectors/source-close-com/source_close_com/manifest.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,10 @@ definitions:
name: "email_thread_activities"
path: "activity/emailthread"
email_activities_stream:
$ref: "#/definitions/activities_base_stream"
$ref: "#/definitions/base_stream"
incremental_sync:
$ref: "#/definitions/incremental_sync__cursor_date_created"
$parameters:
$ref: "#/definitions/activities_base_stream/$parameters"
name: "email_activities"
path: "activity/email"
sms_activities_stream:
Expand Down
12 changes: 12 additions & 0 deletions ...grations/connectors/source-close-com/source_close_com/schemas/activity_custom_fields.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@
"description": {
"date_updated": ["null", "string"]
},
"back_reference_is_visible": {
"date_updated": ["null", "boolean"]
},
"choices": {
"date_updated": ["null", "array"]
},
"is_shared": {
"date_updated": ["null", "boolean"]
},
"referenced_custom_type_id": {
"date_updated": ["null", "string"]
},
"name": {
"date_updated": ["null", "string"]
},
Expand Down
24 changes: 24 additions & 0 deletions ...te-integrations/connectors/source-close-com/source_close_com/schemas/call_activities.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,30 @@
"source": {
"type": ["null", "string"]
},
"forwarded_to": {
"type": ["null", "string"]
},
"is_forwarded": {
"type": ["null", "boolean"]
},
"note_html": {
"type": ["null", "string"]
},
"parent_meeting_id": {
"type": ["null", "string"]
},
"recording_duration": {
"type": ["null", "string"]
},
"sequence_id": {
"type": ["null", "string"]
},
"sequence_name": {
"type": ["null", "string"]
},
"sequence_subscription_id": {
"type": ["null", "string"]
},
"remote_phone_formatted": {
"type": ["null", "string"]
},
Expand Down
9 changes: 9 additions & 0 deletions ...egrations/connectors/source-close-com/source_close_com/schemas/contact_custom_fields.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
"name": {
"date_updated": ["null", "string"]
},
"back_reference_is_visible": {
"date_updated": ["null", "string"]
},
"is_shared": {
"date_updated": ["null", "boolean"]
},
"referenced_custom_type_id": {
"date_updated": ["null", "string"]
},
"choices": {
"date_updated": ["null", "array"]
},
Expand Down
3 changes: 3 additions & 0 deletions ...integrations/connectors/source-close-com/source_close_com/schemas/created_activities.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
"date_updated": {
"type": ["null", "string"]
},
"activity_at": {
"type": ["null", "string"]
},
"date_created": {
"type": ["null", "string"]
},
Expand Down
6 changes: 6 additions & 0 deletions ...tegrations/connectors/source-close-com/source_close_com/schemas/email_followup_tasks.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@
"view": {
"type": ["null", "string"]
},
"total_emails_count_in_thread": {
"type": ["null", "integer"]
},
"updated_by_name": {
"type": ["null", "string"]
},
"assigned_to": {
"type": ["null", "string"]
},
Expand Down
6 changes: 6 additions & 0 deletions airbyte-integrations/connectors/source-close-com/source_close_com/schemas/events.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@
"api_key_id": {
"type": ["null", "string"]
},
"oauth_client_id": {
"type": ["null", "string"]
},
"oauth_scope": {
"type": ["null", "string"]
},
"changed_fields": {
"type": ["null", "array"]
},
Expand Down
9 changes: 9 additions & 0 deletions ...integrations/connectors/source-close-com/source_close_com/schemas/lead_custom_fields.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
"description": {
"date_updated": ["null", "string"]
},
"back_reference_is_visible": {
"date_updated": ["null", "string"]
},
"date_updated": {
"date_updated": ["null", "string"]
},
"referenced_custom_type_id": {
"date_updated": ["null", "string"]
},
"name": {
"date_updated": ["null", "string"]
},
Expand Down
51 changes: 51 additions & 0 deletions ...integrations/connectors/source-close-com/source_close_com/schemas/meeting_activities.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,57 @@
"date_updated": {
"type": ["null", "string"]
},
"activity_at": {
"type": ["null", "string"]
},
"contact_id": {
"type": ["null", "string"]
},
"notetaker_id": {
"type": ["null", "string"]
},
"provider_calendar_event_id": {
"type": ["null", "string"]
},
"provider_calendar_type": {
"type": ["null", "string"]
},
"summary": {
"type": ["null", "string"]
},
"user_note": {
"type": ["null", "string"]
},
"user_note_date_updated": {
"type": ["null", "string"]
},
"user_note_html": {
"type": ["null", "string"]
},
"provider_calendar_ids": {
"type": ["null", "array"],
"items": {
"type": ["null", "string"]
}
},
"integrations": {
"type": ["null", "array"],
"items": {
"type": ["null", "string"]
}
},
"calendar_event_uids": {
"type": ["null", "array"],
"items": {
"type": ["null", "string"]
}
},
"conference_links": {
"type": ["null", "array"],
"items": {
"type": ["null", "string"]
}
},
"created_by_name": {
"type": ["null", "string"]
},
Expand Down
9 changes: 9 additions & 0 deletions ...tions/connectors/source-close-com/source_close_com/schemas/opportunity_custom_fields.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@
"name": {
"date_updated": ["null", "string"]
},
"back_reference_is_visible": {
"date_updated": ["null", "string"]
},
"is_shared": {
"date_updated": ["null", "boolean"]
},
"referenced_custom_type_id": {
"date_updated": ["null", "string"]
},
"choices": {
"date_updated": ["null", "array"]
},
Expand Down
21 changes: 21 additions & 0 deletions ...ctors/source-close-com/source_close_com/schemas/opportunity_status_change_activities.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,27 @@
"date_created": {
"type": ["null", "string"]
},
"activity_at": {
"type": ["null", "string"]
},
"new_pipeline_name": {
"type": ["null", "string"]
},
"users": {
"type": ["null", "array"],
"items": {
"type": ["null", "string"]
}
},
"opportunity_value_period": {
"type": ["null", "string"]
},
"old_pipeline_name": {
"type": ["null", "string"]
},
"opportunity_confidence": {
"type": ["null", "integer"]
},
"date_updated": {
"type": ["null", "string"]
},
Expand Down
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-close-com/source_close_com/schemas/pipelines.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
"created_by": {
"type": ["null", "string"]
},
"updated_by": {
"type": ["null", "string"]
},
"date_updated": {
"type": ["null", "string"]
},
Expand Down
30 changes: 30 additions & 0 deletions ...yte-integrations/connectors/source-close-com/source_close_com/schemas/sms_activities.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,36 @@
"date_updated": {
"type": ["null", "string"]
},
"activity_at": {
"type": ["null", "string"]
},
"attachments": {
"type": ["null", "array"]
},
"date_scheduled": {
"type": ["null", "string"]
},
"error_message": {
"type": ["null", "string"]
},
"local_phone_formatted": {
"type": ["null", "string"]
},
"sequence_id": {
"type": ["null", "string"]
},
"sequence_name": {
"type": ["null", "string"]
},
"sequence_subscription_id": {
"type": ["null", "string"]
},
"source": {
"type": ["null", "string"]
},
"template_id": {
"type": ["null", "string"]
},
"date_created": {
"type": ["null", "string"]
},
Expand Down
15 changes: 15 additions & 0 deletions ...tions/connectors/source-close-com/source_close_com/schemas/task_completed_activities.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,21 @@
"id": {
"type": ["null", "string"]
},
"activity_at": {
"type": ["null", "string"]
},
"task_assigned_to": {
"type": ["null", "string"]
},
"task_assigned_to_name": {
"type": ["null", "string"]
},
"user_name": {
"type": ["null", "string"]
},
"users": {
"type": ["null", "array"]
},
"task_id": {
"type": ["null", "string"]
},
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/close-com.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ The Close.com connector is subject to rate limits. For more information on this

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:-------------------------------------------------------------------------------------------------------|
| 0.4.3 | 2023-10-28 | [31534](https://github.com/airbytehq/airbyte/pull/31534) | Fixed Email Activities Stream Pagination |
| 0.4.2 | 2023-08-08 | [29206](https://github.com/airbytehq/airbyte/pull/29206) | Fixed the issue with `DatePicker` format for `start date` |
| 0.4.1 | 2023-07-04 | [27950](https://github.com/airbytehq/airbyte/pull/27950) | Add human readable titles to API Key and Start Date fields |
| 0.4.0 | 2023-06-27 | [27776](https://github.com/airbytehq/airbyte/pull/27776) | Update the `Email Followup Tasks` stream schema |
Expand Down

0 comments on commit a7f6928

Please sign in to comment.