-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🎉 New Source: Google Analytics v4 Service Account Only (#34323)
- Loading branch information
Showing
25 changed files
with
1,190 additions
and
2 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
...yte-integrations/connectors/source-google-analytics-v4-service-account-only/.dockerignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
* | ||
!Dockerfile | ||
!Dockerfile.test | ||
!main.py | ||
!source_google_analytics_v4_service_account_only | ||
!setup.py | ||
!secrets |
149 changes: 149 additions & 0 deletions
149
...tegrations/connectors/source-google-analytics-v4-service-account-only/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,149 @@ | ||
# Google Analytics V4 (Service Account Only) Source | ||
|
||
This is the repository for the Google Analytics V4 source connector, written in Python. | ||
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/sources/google-analytics-v4). | ||
|
||
## Local development | ||
|
||
### Prerequisites | ||
**To iterate on this connector, make sure to complete this prerequisites section.** | ||
|
||
#### Minimum Python version required `= 3.7.0` | ||
|
||
#### Build & Activate Virtual Environment and install dependencies | ||
From this connector directory, create a virtual environment: | ||
``` | ||
python -m venv .venv | ||
``` | ||
|
||
This will generate a virtualenv for this module in `.venv/`. Make sure this venv is active in your | ||
development environment of choice. To activate it from the terminal, run: | ||
``` | ||
source .venv/bin/activate | ||
pip install -r requirements.txt | ||
``` | ||
If you are in an IDE, follow your IDE's instructions to activate the virtualenv. | ||
|
||
Note that while we are installing dependencies from `requirements.txt`, you should only edit `setup.py` for your dependencies. `requirements.txt` is | ||
used for editable installs (`pip install -e`) to pull in Python dependencies from the monorepo and will call `setup.py`. | ||
If this is mumbo jumbo to you, don't worry about it, just put your deps in `setup.py` but install using `pip install -r requirements.txt` and everything | ||
should work as you expect. | ||
|
||
#### Create credentials | ||
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/sources/google-analytics-v4) | ||
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `source_google_analytics_v4/spec.json` file. | ||
Note that any directory named `secrets` is gitignored across the entire Airbyte repo, so there is no danger of accidentally checking in sensitive information. | ||
See `integration_tests/sample_config.json` for a sample config file. | ||
|
||
**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `source google-analytics-v4-service-account-only test creds` | ||
and place them into `secrets/config.json`. | ||
|
||
### Locally running the connector | ||
``` | ||
python main.py spec | ||
python main.py check --config secrets/config.json | ||
python main.py discover --config secrets/config.json | ||
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json | ||
``` | ||
|
||
### Locally running the connector docker image | ||
|
||
|
||
|
||
#### Use `airbyte-ci` to build your connector | ||
The Airbyte way of building this connector is to use our `airbyte-ci` tool. | ||
You can follow install instructions [here](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md#L1). | ||
Then running the following command will build your connector: | ||
|
||
```bash | ||
airbyte-ci connectors --name=source-google-analytics-v4-service-account-only build | ||
``` | ||
Once the command is done, you will find your connector image in your local docker registry: `airbyte/source-google-analytics-v4-service-account-only:dev`. | ||
|
||
##### Customizing our build process | ||
When contributing on our connector you might need to customize the build process to add a system dependency or set an env var. | ||
You can customize our build process by adding a `build_customization.py` module to your connector. | ||
This module should contain a `pre_connector_install` and `post_connector_install` async function that will mutate the base image and the connector container respectively. | ||
It will be imported at runtime by our build process and the functions will be called if they exist. | ||
|
||
Here is an example of a `build_customization.py` module: | ||
```python | ||
from __future__ import annotations | ||
|
||
from typing import TYPE_CHECKING | ||
|
||
if TYPE_CHECKING: | ||
# Feel free to check the dagger documentation for more information on the Container object and its methods. | ||
# https://dagger-io.readthedocs.io/en/sdk-python-v0.6.4/ | ||
from dagger import Container | ||
|
||
|
||
async def pre_connector_install(base_image_container: Container) -> Container: | ||
return await base_image_container.with_env_variable("MY_PRE_BUILD_ENV_VAR", "my_pre_build_env_var_value") | ||
|
||
async def post_connector_install(connector_container: Container) -> Container: | ||
return await connector_container.with_env_variable("MY_POST_BUILD_ENV_VAR", "my_post_build_env_var_value") | ||
``` | ||
|
||
#### Build your own connector image | ||
This connector is built using our dynamic built process in `airbyte-ci`. | ||
The base image used to build it is defined within the metadata.yaml file under the `connectorBuildOptions`. | ||
The build logic is defined using [Dagger](https://dagger.io/) [here](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/pipelines/builds/python_connectors.py). | ||
It does not rely on a Dockerfile. | ||
|
||
If you would like to patch our connector and build your own a simple approach would be to: | ||
|
||
1. Create your own Dockerfile based on the latest version of the connector image. | ||
```Dockerfile | ||
FROM airbyte/source-google-analytics-v4-service-account-only:latest | ||
|
||
COPY . ./airbyte/integration_code | ||
RUN pip install ./airbyte/integration_code | ||
|
||
# The entrypoint and default env vars are already set in the base image | ||
# ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" | ||
# ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] | ||
``` | ||
Please use this as an example. This is not optimized. | ||
|
||
2. Build your image: | ||
```bash | ||
docker build -t airbyte/source-google-analytics-v4-service-account-only:dev . | ||
# Running the spec command against your patched connector | ||
docker run airbyte/source-google-analytics-v4-service-account-only:dev spec | ||
``` | ||
#### Run | ||
Then run any of the connector commands as follows: | ||
``` | ||
docker run --rm airbyte/source-google-analytics-v4-service-account-only:dev spec | ||
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-google-analytics-v4-service-account-only:dev check --config /secrets/config.json | ||
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-google-analytics-v4-service-account-only:dev discover --config /secrets/config.json | ||
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-google-analytics-v4-service-account-only:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json | ||
``` | ||
|
||
## Testing | ||
You can run our full test suite locally using [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md): | ||
```bash | ||
airbyte-ci connectors --name=source-google-analytics-v4 test | ||
``` | ||
|
||
### Customizing acceptance Tests | ||
Customize `acceptance-test-config.yml` file to configure tests. See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference) for more information. | ||
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py. | ||
|
||
## Dependency Management | ||
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development. | ||
We split dependencies between two groups, dependencies that are: | ||
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list. | ||
* required for the testing need to go to `TEST_REQUIREMENTS` list | ||
|
||
### Publishing a new version of the connector | ||
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what? | ||
1. Make sure your changes are passing our test suite: `airbyte-ci connectors --name=source-google-analytics-v4-service-account-only test` | ||
2. Bump the connector version in `metadata.yaml`: increment the `dockerImageTag` value. Please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors). | ||
3. Make sure the `metadata.yaml` content is up to date. | ||
4. Make the connector documentation and its changelog is up to date (`docs/integrations/sources/google-analytics-v4-service-account-only.md`). | ||
5. Create a Pull Request: use [our PR naming conventions](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#pull-request-title-convention). | ||
6. Pat yourself on the back for being an awesome contributor. | ||
7. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master. | ||
|
35 changes: 35 additions & 0 deletions
35
...ons/connectors/source-google-analytics-v4-service-account-only/acceptance-test-config.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
connector_image: airbyte/source-google-analytics-v4-service-account-only:dev | ||
test_strictness_level: high | ||
acceptance_tests: | ||
spec: | ||
tests: | ||
- spec_path: source_google_analytics_v4_service_account_only/spec.json | ||
discovery: | ||
tests: | ||
- config_path: secrets/config.json | ||
connection: | ||
tests: | ||
- config_path: secrets/config.json | ||
status: succeed | ||
- config_path: integration_tests/invalid_config.json | ||
status: exception | ||
basic_read: | ||
tests: | ||
- config_path: secrets/config.json | ||
empty_streams: | ||
- name: users_per_city | ||
bypass_reason: no records in the stream | ||
expect_records: | ||
path: integration_tests/expected_records.jsonl | ||
timeout_seconds: 1800 | ||
full_refresh: | ||
tests: | ||
- config_path: secrets/config.json | ||
configured_catalog_path: integration_tests/configured_catalog.json | ||
incremental: | ||
tests: | ||
- config_path: secrets/config.json | ||
configured_catalog_path: integration_tests/configured_catalog.json | ||
timeout_seconds: 2400 | ||
future_state: | ||
future_state_path: integration_tests/abnormal_state.json |
1 change: 1 addition & 0 deletions
1
...ntegrations/connectors/source-google-analytics-v4-service-account-only/icon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions
23
.../connectors/source-google-analytics-v4-service-account-only/integration_tests/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# | ||
# MIT License | ||
# | ||
# Copyright (c) 2020 Airbyte | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included in all | ||
# copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
# |
86 changes: 86 additions & 0 deletions
86
...ors/source-google-analytics-v4-service-account-only/integration_tests/abnormal_state.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
[ | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "website_overview" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "traffic_sources" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "pages" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "locations" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "monthly_active_users" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "four_weekly_active_users" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "two_weekly_active_users" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "weekly_active_users" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "daily_active_users" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "devices" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "users_per_day" } | ||
} | ||
}, | ||
{ | ||
"type": "STREAM", | ||
"stream": { | ||
"stream_state": { "ga_date": "2050-05-01" }, | ||
"stream_descriptor": { "name": "new_users_per_day" } | ||
} | ||
} | ||
] |
13 changes: 13 additions & 0 deletions
13
...onnectors/source-google-analytics-v4-service-account-only/integration_tests/acceptance.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# | ||
# Copyright (c) 2023 Airbyte, Inc., all rights reserved. | ||
# | ||
|
||
|
||
import pytest | ||
|
||
pytest_plugins = ("connector_acceptance_test.plugin",) | ||
|
||
|
||
@pytest.fixture(scope="session", autouse=True) | ||
def connector_setup(): | ||
yield |
Oops, something went wrong.