In Cloud, out of date connectors call always returns 0 (#21126)

* isCloudApp returns a boolean now

* Connector service never makes the check updates call in Cloud

airbyte-webapp/src/services/connector/ConnectorService.ts

@@ -1,11 +1,15 @@
 import { useConfig } from "config";
-import { webBackendCheckUpdates } from "core/request/AirbyteClient";
+import { webBackendCheckUpdates, WebBackendCheckUpdatesRead } from "core/request/AirbyteClient";
 import { AirbyteRequestService } from "core/request/AirbyteRequestService";
 import { useDefaultRequestMiddlewares } from "services/useDefaultRequestMiddlewares";
 import { useInitService } from "services/useInitService";
+import { isCloudApp } from "utils/app";
 
 class ConnectorService extends AirbyteRequestService {
-  checkUpdates() {
+  checkUpdates(): Promise<WebBackendCheckUpdatesRead> {
+    if (isCloudApp()) {
+      return Promise.resolve({ sourceDefinitions: 0, destinationDefinitions: 0 });
+    }
     return webBackendCheckUpdates(this.requestOptions);
   }
 }

airbyte-webapp/src/utils/app.ts

@@ -1 +1 @@
-export const isCloudApp = () => process.env.REACT_APP_CLOUD || window.CLOUD === "true";
+export const isCloudApp = () => (process.env.REACT_APP_CLOUD || window.CLOUD) === "true";