Source strava: update docs + http -> https (#24368)

* Source Strava: http -> https * Source Strava: update docs * Source Strava: update docs * Source Strava: update docs * Source Strava: add allowed hosts * Automated Change * Source Strava: add date-time format * Source Strava: add date-time format * auto-bump connector version --------- Co-authored-by: artem1205 <artem1205@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
airbytehq · Mar 23, 2023 · c279913 · c279913
1 parent 38457bf
commit c279913
Show file tree

Hide file tree

Showing 10 changed files with 37 additions and 57 deletions.
diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -1946,11 +1946,14 @@
 - sourceDefinitionId: 7a4327c4-315a-11ec-8d3d-0242ac130003
   name: Strava
   dockerRepository: airbyte/source-strava
-  dockerImageTag: 0.1.3
+  dockerImageTag: 0.1.4
   documentationUrl: https://docs.airbyte.com/integrations/sources/strava
   icon: strava.svg
   sourceType: api
-  releaseStage: alpha
+  releaseStage: beta
+  allowedHosts:
+    hosts:
+      - strava.com
 - name: Statuspage
   sourceDefinitionId: 74cbd708-46c3-4512-9c93-abd5c3e9a94d
   dockerRepository: airbyte/source-statuspage

diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml
@@ -14809,11 +14809,11 @@
               path_in_connector_config:
               - "credentials"
               - "client_secret"
-- dockerImage: "airbyte/source-strava:0.1.3"
+- dockerImage: "airbyte/source-strava:0.1.4"
   spec:
     documentationUrl: "https://docs.airbyte.com/integrations/sources/strava"
     connectionSpecification:
-      $schema: "http://json-schema.org/draft-07/schema#"
+      $schema: "https://json-schema.org/draft-07/schema#"
       title: "Strava Spec"
       type: "object"
       required:
@@ -14869,7 +14869,8 @@
           description: "UTC date and time. Any data before this date will not be replicated."
           title: "Start Date"
           examples:
-          - "2016-12-31 23:59:59"
+          - "2021-03-01T00:00:00Z"
+          format: "date-time"
           order: 4
     supportsNormalization: false
     supportsDBT: false

diff --git a/airbyte-integrations/connectors/source-strava/Dockerfile b/airbyte-integrations/connectors/source-strava/Dockerfile
@@ -34,5 +34,5 @@ COPY source_strava ./source_strava
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.3
+LABEL io.airbyte.version=0.1.4
 LABEL io.airbyte.name=airbyte/source-strava
diff --git a/airbyte-integrations/connectors/source-strava/integration_tests/configured_catalog.json b/airbyte-integrations/connectors/source-strava/integration_tests/configured_catalog.json
@@ -4,7 +4,7 @@
       "stream": {
         "name": "athlete_stats",
         "json_schema": {
-          "$schema": "http://json-schema.org/draft-04/schema#",
+          "$schema": "https://json-schema.org/draft-07/schema#",
           "type": "object",
           "properties": {
             "athlete_id": {
@@ -21,7 +21,7 @@
       "stream": {
         "name": "activities",
         "json_schema": {
-          "$schema": "http://json-schema.org/draft-04/schema#",
+          "$schema": "https://json-schema.org/draft-07/schema#",
           "type": "object",
           "properties": {
             "start_date": {

diff --git a/airbyte-integrations/connectors/source-strava/sample_files/configured_catalog.json b/airbyte-integrations/connectors/source-strava/sample_files/configured_catalog.json
diff --git a/airbyte-integrations/connectors/source-strava/source_strava/schemas/activities.json b/airbyte-integrations/connectors/source-strava/source_strava/schemas/activities.json
@@ -1,5 +1,5 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
+  "$schema": "https://json-schema.org/draft-07/schema#",
   "type": "object",
   "additionalProperties": true,
   "properties": {

diff --git a/airbyte-integrations/connectors/source-strava/source_strava/schemas/athlete_stats.json b/airbyte-integrations/connectors/source-strava/source_strava/schemas/athlete_stats.json
@@ -1,5 +1,5 @@
 {
-  "$schema": "http://json-schema.org/draft-07/schema#",
+  "$schema": "https://json-schema.org/draft-07/schema#",
   "type": "object",
   "additionalProperties": true,
   "properties": {

diff --git a/airbyte-integrations/connectors/source-strava/source_strava/spec.json b/airbyte-integrations/connectors/source-strava/source_strava/spec.json
@@ -1,7 +1,7 @@
 {
   "documentationUrl": "https://docs.airbyte.com/integrations/sources/strava",
   "connectionSpecification": {
-    "$schema": "http://json-schema.org/draft-07/schema#",
+    "$schema": "https://json-schema.org/draft-07/schema#",
     "title": "Strava Spec",
     "type": "object",
     "required": [
@@ -57,7 +57,8 @@
         "type": "string",
         "description": "UTC date and time. Any data before this date will not be replicated.",
         "title": "Start Date",
-        "examples": ["2016-12-31 23:59:59"],
+        "examples": ["2021-03-01T00:00:00Z"],
+        "format": "date-time",
         "order": 4
       }
     }

diff --git a/connectors.md b/connectors.md
@@ -225,7 +225,7 @@
 | **SpaceX API** | <img alt="SpaceX API icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/spacex.svg" height="30" height="30"/> | Source | airbyte/source-spacex-api:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/spacex-api) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-spacex-api) | <small>`62235e65-af7a-4138-9130-0bda954eb6a8`</small> |
 | **Square** | <img alt="Square icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/square.svg" height="30" height="30"/> | Source | airbyte/source-square:0.2.1 | beta | [link](https://docs.airbyte.com/integrations/sources/square) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-square) | <small>`77225a51-cd15-4a13-af02-65816bd0ecf4`</small> |
 | **Statuspage** | <img alt="Statuspage icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/statuspage.svg" height="30" height="30"/> | Source | airbyte/source-statuspage:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/statuspage) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-statuspage) | <small>`74cbd708-46c3-4512-9c93-abd5c3e9a94d`</small> |
-| **Strava** | <img alt="Strava icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/strava.svg" height="30" height="30"/> | Source | airbyte/source-strava:0.1.3 | alpha | [link](https://docs.airbyte.com/integrations/sources/strava) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-strava) | <small>`7a4327c4-315a-11ec-8d3d-0242ac130003`</small> |
+| **Strava** | <img alt="Strava icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/strava.svg" height="30" height="30"/> | Source | airbyte/source-strava:0.1.4 | beta | [link](https://docs.airbyte.com/integrations/sources/strava) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-strava) | <small>`7a4327c4-315a-11ec-8d3d-0242ac130003`</small> |
 | **Stripe** | <img alt="Stripe icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/stripe.svg" height="30" height="30"/> | Source | airbyte/source-stripe:3.0.3 | generally_available | [link](https://docs.airbyte.com/integrations/sources/stripe) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-stripe) | <small>`e094cb9a-26de-4645-8761-65c0c425d1de`</small> |
 | **SurveyCTO** | <img alt="SurveyCTO icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/surveycto.svg" height="30" height="30"/> | Source | airbyte/source-surveycto:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/surveycto) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-surveycto) | <small>`dd4632f4-15e0-4649-9b71-41719fb1fdee`</small> |
 | **SurveyMonkey** | <img alt="SurveyMonkey icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/surveymonkey.svg" height="30" height="30"/> | Source | airbyte/source-surveymonkey:0.1.15 | generally_available | [link](https://docs.airbyte.com/integrations/sources/surveymonkey) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-surveymonkey) | <small>`badc5925-0485-42be-8caa-b34096cb71b5`</small> |

diff --git a/docs/integrations/sources/strava.md b/docs/integrations/sources/strava.md
@@ -1,8 +1,11 @@
-# 
-
 # Strava
 
-This page guides you through the process of setting up the Strava    source connector.
+This page guides you through the process of setting up the Strava source connector.
+
+## Prerequisites
+
+Scopes:
+* `activity:read_all`
 
 ## Setup guide
 ### Step 1: Set up Strava
@@ -16,9 +19,9 @@ Follow these steps to get the required credentials and inputs:
     * Continue to follow the instructions from the doc above to obtain `client_id` and `client_secret`
 * `refresh_token`
     * Enter this URL into your browser (make sure to add your `client_id` from previous step:
-        * `http://www.strava.com/oauth/authorize?client_id=[REPLACE_WITH_YOUR_CLIENT_ID]&response_type=code&redirect_uri=http://localhost/exchange_token&approval_prompt=force&scope=activity:read_all`
+        * `https://www.strava.com/oauth/authorize?client_id=[REPLACE_WITH_YOUR_CLIENT_ID]&response_type=code&redirect_uri=https://localhost/exchange_token&approval_prompt=force&scope=activity:read_all`
     * Authorize through the UI
-    * Browser will redirect you to an empty page with a URL similar to `http://localhost/exchange_token?state=&code=b55003496d87a9f0b694ca1680cd5690d27d9d28&scope=activity:read_all`
+    * Browser will redirect you to an empty page with a URL similar to `https://localhost/exchange_token?state=&code=b55003496d87a9f0b694ca1680cd5690d27d9d28&scope=activity:read_all`
     * Copy the authorization code above (in this example it would be `b55003496d87a9f0b694ca1680cd5690d27d9d28`)
     * Make a cURL request to exchange the authorization code and scope for a refresh token:
     * ```
@@ -92,7 +95,16 @@ Follow these steps to get the required credentials and inputs:
 6. Click `Set up source`.
 <!-- /env:oss -->
 
-## Supported streams and sync modes
+## Supported sync modes
+
+The Strava source connector supports the following [sync modes](https://docs.airbyte.com/cloud/core-concepts#connection-sync-modes):
+
+- [Full Refresh - Overwrite](https://docs.airbyte.com/understanding-airbyte/connections/full-refresh-overwrite/)
+- [Full Refresh - Append](https://docs.airbyte.com/understanding-airbyte/connections/full-refresh-append)
+- [Incremental Sync - Append](https://docs.airbyte.com/understanding-airbyte/connections/incremental-append)
+- [Incremental Sync - Deduped History](https://docs.airbyte.com/understanding-airbyte/connections/incremental-deduped-history)
+
+## Supported streams
 
 * [Athlete Stats](https://developers.strava.com/docs/reference/#api-Athletes-getStats)
 * [Activities](https://developers.strava.com/docs/reference/#api-Activities-getLoggedInAthleteActivities) \(Incremental\)
@@ -106,6 +118,7 @@ More information about Strava rate limits and adjustments to those limits can be
 
 | Version | Date       | Pull Request                                             | Subject                                                    |
 |:--------|:-----------|:---------------------------------------------------------|:-----------------------------------------------------------|
+| 0.1.4   | 2023-03-23 | [24368](https://github.com/airbytehq/airbyte/pull/24368) | Add date-time format for input                             |
 | 0.1.3   | 2023-03-15 | [24101](https://github.com/airbytehq/airbyte/pull/24101) | certified to beta, fixed spec, fixed SAT, added unit tests |
 | 0.1.2   | 2021-12-15 | [8799](https://github.com/airbytehq/airbyte/pull/8799)   | Implement OAuth 2.0 support                                |
 | 0.1.1   | 2021-12-06 | [8425](https://github.com/airbytehq/airbyte/pull/8425)   | Update title, description fields in spec                   |