Skip to content

Commit

Permalink
fix publish-java-cdk workflow on push-to-master (#36975)
Browse files Browse the repository at this point in the history
the publish-java-cdk on push-to-master wasn't working because the value of dry-run was set to true. 
I'm also adding some debugging info so we know what the values of DRY_RUN and FORCE are

This was tested on my fork of the airbyte repo
  • Loading branch information
stephane-airbyte authored Apr 11, 2024
1 parent 5a1edcc commit f30f678
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/publish-java-cdk-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ env:
# Use the provided GITREF or default to the branch triggering the workflow.
GITREF: ${{ github.event.inputs.gitref || github.ref }}
FORCE: "${{ github.event_name == 'push' || github.event.inputs.force == null && 'false' || github.event.inputs.force }}"
DRY_RUN: "${{ github.event.inputs.dry-run == null && 'true' || github.event.inputs.dry-run }}"
DRY_RUN: "${{ github.event_name == 'push' && 'false' || github.event.inputs.dry-run == null && 'true' || github.event.inputs.dry-run }}"
CDK_VERSION_FILE_PATH: "./airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties"
S3_BUILD_CACHE_ACCESS_KEY_ID: ${{ secrets.SELF_RUNNER_AWS_ACCESS_KEY_ID }}
S3_BUILD_CACHE_SECRET_KEY: ${{ secrets.SELF_RUNNER_AWS_SECRET_ACCESS_KEY }}
Expand Down Expand Up @@ -77,6 +77,9 @@ jobs:
id: read-target-java-cdk-version
run: |
cdk_version=$(cat $CDK_VERSION_FILE_PATH | tr -d '\n')
echo "CDK_VERSION=$CDK_VERSION"
echo "FORCE=$FORCE"
echo "DRY_RUN=$DRY_RUN"
if [[ -z "$cdk_version" ]]; then
echo "Failed to retrieve CDK version from $CDK_VERSION_FILE_PATH"
exit 1
Expand Down

0 comments on commit f30f678

Please sign in to comment.