Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove demo mode from UI #15648

Closed
timroes opened this issue Aug 15, 2022 · 7 comments · Fixed by #15746
Closed

Remove demo mode from UI #15648

timroes opened this issue Aug 15, 2022 · 7 comments · Fixed by #15746
Assignees
Labels
area/frontend Related to the Airbyte webapp technical-debt issues to fix code smell

Comments

@timroes
Copy link
Contributor

timroes commented Aug 15, 2022

image.png

We currently have the possibility to specify a demo mode (if window.IS_DEMO is set to true). This mode is only used to show a banner notification that you're in the demo. We should use any of our third party tools (like google optimize) to show a banner instead.

Long term the demo instance should move to Cloud: https://github.com/airbytehq/airbyte-internal-issues/issues/750

  • Remove demo mode from webapp
  • Remove IS_DEMO from build configurations and docs.
  • Remove any other areas not mentioned here (search for isDemo and IS_DEMO in code)
  • Verify that there are no IS_DEMO references in airbyte-cloud. Do not remove helm charts
  • Coordinate with @nataliekwong to add banner notification - Deploy built version and show banner with third-party tool
@timroes timroes added technical-debt issues to fix code smell area/frontend Related to the Airbyte webapp labels Aug 15, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@nataliekwong
Copy link
Contributor

The banner is ready to be deployed through Google Optimize whenever we get the OK here. Note we also made the following changes to systems:

  1. Added Google Tag Manager to Segment source for the demo
  2. Added a trigger to Google Tag Manager to fire Google Optimize on all visits to demo.airbyte.io

Screenshot of the banner in preview (link goes to /signup):
Screen Shot 2022-08-15 at 9 23 25 PM

@johnlafleur
Copy link
Contributor

I don't think the "Try it yourself" is self-explanatory as CTA, and also is visible enough...
Maybe "Try Airbyte Cloud for free with your own data", and make it more visible, purple possibly and bold?

@nataliekwong
Copy link
Contributor

How's this @johnlafleur ?

Screen Shot 2022-08-23 at 7 31 51 PM

@lmossman
Copy link
Contributor

lmossman commented Aug 23, 2022

@nataliekwong I have merged the PR to remove the demo mode UI code from the app, so you can go ahead and turn on the Google Optimize banner when ready.

We will also need to redeploy the demo app again so that the old demo banner is not shown anymore. We probably want to do that around the same time that the google optimize banner is applied, so let me know when you want to coordinate that (or feel free to grab 15 mins on my calendar if you want to do it over zoom)

@lmossman lmossman reopened this Aug 23, 2022
@johnlafleur
Copy link
Contributor

johnlafleur commented Aug 24, 2022 via email

@lmossman
Copy link
Contributor

lmossman commented Aug 26, 2022

The most recent version of airbyte that excludes the old demo banner has been deployed to the demo instance, and the Google Optimize banner has been turned on! Going to close this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp technical-debt issues to fix code smell
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants