-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove demo mode from UI #15648
Comments
cc @airbytehq/frontend |
The banner is ready to be deployed through Google Optimize whenever we get the OK here. Note we also made the following changes to systems:
|
I don't think the "Try it yourself" is self-explanatory as CTA, and also is visible enough... |
How's this @johnlafleur ? |
@nataliekwong I have merged the PR to remove the demo mode UI code from the app, so you can go ahead and turn on the Google Optimize banner when ready. We will also need to redeploy the demo app again so that the old demo banner is not shown anymore. We probably want to do that around the same time that the google optimize banner is applied, so let me know when you want to coordinate that (or feel free to grab 15 mins on my calendar if you want to do it over zoom) |
Looks good in your mockup.
*--*
*John Lafleur*
Co-Founder & COO
LinkedIn <https://www.linkedin.com/in/jeanhenrilafleur/> | Twitter
<https://twitter.com/JeanLafleur>
<http://movedata.airbyte.com>
We're hiring, come work with us! <https://boards.greenhouse.io/airbyte>
…On Tue, Aug 23, 2022 at 4:47 PM Lake Mossman ***@***.***> wrote:
@nataliekwong <https://github.com/nataliekwong> I have merged the PR to
remove the demo mode UI code from the app, so you can go ahead and turn on
the Google Optimize banner when ready.
We will also need to redeploy the demo app again so that the old demo
banner is not shown anymore. We probably want to do that around the same
time that the google optimize banner is applied, so let me know when you
want to coordinate that!
—
Reply to this email directly, view it on GitHub
<#15648 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQLCVQWICDB5WLNWYS53Z4LV2VPKTANCNFSM56RTK4DA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The most recent version of airbyte that excludes the old demo banner has been deployed to the demo instance, and the Google Optimize banner has been turned on! Going to close this out |
We currently have the possibility to specify a demo mode (if
window.IS_DEMO
is set to true). This mode is only used to show a banner notification that you're in the demo. We should use any of our third party tools (like google optimize) to show a banner instead.Long term the demo instance should move to Cloud: https://github.com/airbytehq/airbyte-internal-issues/issues/750
IS_DEMO
from build configurations and docs.isDemo
andIS_DEMO
in code)IS_DEMO
references inairbyte-cloud
. Do not remove helm chartsThe text was updated successfully, but these errors were encountered: