-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The action runner EC2 image used for connector publication may not have enough resource #16265
Comments
@davinchia, FYI. |
Thanks Liren! |
We are in the Github beta which would allow us to use "very big" servers to run Github actions. We could skip all the AWS meshugas and maybe go back to using Github Actions. cc @supertopher Details over in https://github.com/airbytehq/airbyte-cloud/issues/2737 |
@git-phu can you let me know if the AMIs here have been updated with the work last week? |
@evantahler they have not Last week we tried some experiments with preloading some things into runner AMIs but we did not find significant gains with the things we tested so we didn't change any current build images. However, on a separate note I recently updated the cloud pipelines to use a newer AMI that has the latest version of docker/docker compose (and has a 100gb disk), so if we are still encountering the issues originally mentioned in this issue, we could try out this ami |
Ok, great! We'll update to AMI |
@git-phu how much HDD space does the new image made in https://github.com/airbytehq/airbyte-cloud/pull/3424 have? It looks like the /test command and /publish command use different images, and perhaps the main difference is hard drive space? airbyte/.github/actions/start-aws-runner/action.yml Lines 10 to 13 in 894d672
vs airbyte/.github/workflows/test-command.yml Lines 64 to 65 in 894d672
|
@evantahler the new image uses 100gb for disk. |
airbyte/.github/actions/start-aws-runner/action.yml Lines 10 to 13 in 894d672
has 100gb for disk airbyte/.github/workflows/test-command.yml Lines 64 to 65 in 894d672
has 80gb for disk |
afaik 100gb was chosen semi arbitrarily too, so we could just use even bigger disks if that could help avoid some test failures |
Summary
Running integration tests
source-mysql
andsource-mysql-strict-encrypt
by the/test
command completes without any problem, while running the/publish
command for the same two connectors would stuck there for hours.The most recent example is here: #16259
One difference between the
/test
and/publish
command is that the former uses EC2 imageami-0d648081937c75a73
with 80GB disk, while the latter uses the defaultami-0f23be2f917510c26
. I suspect the latter does not have enough disk space or memory to run the integration tests. When I tried to useami-0d648081937c75a73
to run the/publish
command, it failed because there is nodocker buildx
in that image.Could we update
ami-0d648081937c75a73
to have a newer version of docker that supportsdocker buildx
, or add more resource to the defaultami-0f23be2f917510c26
?Here is a summary:
/test
/publish
ami-0d648081937c75a73
ami-0f23be2f917510c26
docker buildx
.docker
withdocker buildx
in this image.The text was updated successfully, but these errors were encountered: