Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Discover Schema fails we should show logs #1697

Closed
cgardens opened this issue Jan 18, 2021 · 3 comments · Fixed by #1821
Closed

When Discover Schema fails we should show logs #1697

cgardens opened this issue Jan 18, 2021 · 3 comments · Fixed by #1821
Assignees
Labels
priority/medium Medium priority type/bug Something isn't working
Milestone

Comments

@cgardens
Copy link
Contributor

cgardens commented Jan 18, 2021

Expected Behavior

  • when discover schema fails we should allow user to retry and we should show the logs.

Current Behavior

  • we allow retrying and say that if fails but don't show logs. We should show logs at the bottom just like we do for check connection.
    Screen Shot 2021-01-18 at 10 52 34 AM
@cgardens cgardens added the type/bug Something isn't working label Jan 18, 2021
@cgardens cgardens added this to the Launch 1.0 milestone Jan 18, 2021
@jamakase
Copy link
Contributor

@cgardens Looks like there is a problem on backend side for this one.

  • I created source and destination with bad params.
  • do discover_schema request in 2 ways:
  1. make request on /v1/scheduler/sources/discover_schema
    Body:
  connectionConfiguration: {
    key_id: "1", 
    vendor: "1", 
    key_file: "1", 
    issuer_id: "1", 
    start_date: "2020-11-11T00:00:00Z"
  },
  sourceDefinitionId: "53a5a3ea-f52f-44e3-8b7d-6a7cc94e5395"
}

Response:

{ message: "Could not find configuration for STANDARD_SOURCE_DEFINITION: 53a5a3ea-f52f-44e3-8b7d-6a7cc94e5395." }
  1. do request on /v1/sources/discover_schema
    Request body:
{
  sourceId: "53a5a3ea-f52f-44e3-8b7d-6a7cc94e5395"
}

Response:

{ message: "internal server error" }

So as you see - there is no jobInfo returned from backend.

Though, I was able to receive logs via /v1/scheduler/sources/discover_schema for a good source only once and that time jobInfo was displayed correctly. Do not know how to force backend send jobInfo again, but when it is present in payload - we display it.

@cgardens
Copy link
Contributor Author

Suggestion for what we should do here: #1821

@jamakase
Copy link
Contributor

Checked after the PR above is merged - works as a charm

davydov-d added a commit that referenced this issue Mar 23, 2023
davydov-d added a commit that referenced this issue Mar 24, 2023
davydov-d added a commit that referenced this issue Mar 27, 2023
* #1697 source S3: read a single record on check

* #1697 source s3: upd changelog

* #1697 source s3: fix unit_tests

* auto-bump connector version

---------

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium Medium priority type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants