Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make integrations self-contained #173

Closed
jrhizor opened this issue Sep 4, 2020 · 4 comments
Closed

make integrations self-contained #173

jrhizor opened this issue Sep 4, 2020 · 4 comments
Assignees
Labels
area/connectors Connector related issues type/enhancement New feature or request
Milestone

Comments

@jrhizor
Copy link
Contributor

jrhizor commented Sep 4, 2020

  • integrations need to be responsible for defining the config spec
  • integration images need an interface to produce the config spec
  • integrations should fail if the provided config is invalid
  • integration tests should fail if validation is not being performed properly or if it can't access the spec
  • integrations should be able to optionally convert their config to a different format (currently only required for BQ, but could be used in the future for postgres, others)
@jrhizor jrhizor added type/enhancement New feature or request area/connectors Connector related issues labels Sep 4, 2020
@jrhizor jrhizor added this to the v1.0 milestone Sep 4, 2020
@cgardens cgardens modified the milestones: v0.1.0, 0.2.0 Sep 24, 2020
@sherifnada sherifnada self-assigned this Oct 6, 2020
@sherifnada
Copy link
Contributor

solved after #528

@cgardens
Copy link
Contributor

cgardens commented Oct 10, 2020

@sherifnada - is moving standard source / standard destination into the integration not part of this task? should we have a separate issue for it? Essentially same question as on this PR comment. Probably easies to just discuss in this isse instead of on the merged PR.

@sherifnada
Copy link
Contributor

@cgardens just saw this comment. Why would moving the entire source/destination definition into the image be part of the task? We still need a registry in the core application of sources/destinations and the docker images/tags they use. This is what standard source/destination currently refer to.

@cgardens
Copy link
Contributor

Let's discuss this tomorrow when we're in person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants