Remove source/destination spec IDs and replace with source/destinationIds in the backend #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-images-to-connectordefs
…ove-internal-integrationsjava
Closed
jrhizor
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
I am very confused with the models naming (doesn't seem to match what we discussed in https://airbytehq.slack.com/archives/C019WEENQRM/p1601672342057100).
|
|
||
| package io.airbyte.commons.docker; | ||
|
|
||
| public class DockerUtil { |
|
|
||
| final Path path = | ||
| Paths.get("../airbyte-server/src/test/resources/json/TestSpecification.json"); | ||
| class DockerUtilTest { |
| - sourceId | ||
| - specification | ||
| - connectionSpecification |
There was a problem hiding this comment.
the naming is confusing here and it introduces a new term connection
what about something like: expectedConfigurations or configurations
| @@ -875,16 +875,46 @@ components: | |||
| properties: | |||
| sourceId: | |||
| $ref: "#/components/schemas/SourceId" | |||
| SourceCreate: | |||
There was a problem hiding this comment.
Shouldn't that be called SourceDefinitionCreate based on https://airbytehq.slack.com/archives/C019WEENQRM/p1601672342057100
| sourceId: | ||
| $ref: "#/components/schemas/SourceId" | ||
| dockerImageTag: | ||
| type: string | ||
| SourceRead: |
| dockerRepository: | ||
| type: string | ||
| dockerImageVersion: | ||
| type: string | ||
| SourceReadList: |
|
@michel-tricot gonna do the rename in a future PR. I felt the scope of these changes was already decently large and was going to disturb Artem's flow more than needed. That ok with you? |
michel-tricot
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes spec IDs as first class citizens from everywhere in the (backend) codebase.