Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🔧 Remove "serviceType" prop from Formik's formValues (<ServiceForm/> refactoring part 2) #18051

Closed
dizel852 opened this issue Oct 17, 2022 · 1 comment · Fixed by #18168
Closed

🪟 🔧 Remove "serviceType" prop from Formik's formValues (<ServiceForm/> refactoring part 2) #18051

dizel852 opened this issue Oct 17, 2022 · 1 comment · Fixed by #18168
Assignees
@dizel852
Labels
area/frontend Related to the Airbyte webapp team/platform-move type/enhancement New feature or request

Comments

@dizel852
Copy link
Contributor

Tell us about the problem you're trying to solve

In part 1 we moved <ConnectorServiceTypeControl /> outside the Formik(context and components).
But serviceType prop is still part of Formik's formValues.

Describe the solution you’d like

Remove serviceType from Formik's formValues and handle it on upper level
@dizel852 dizel852 added type/enhancement New feature or request team/platform-move area/frontend Related to the Airbyte webapp labels Oct 17, 2022
@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@dizel852 dizel852 self-assigned this Oct 17, 2022
@dizel852 dizel852 mentioned this issue Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dizel852 dizel852

Labels
area/frontend Related to the Airbyte webapp team/platform-move type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@dizel852 @octavia-squidington-iv