🪟 🔧 Refactored <ServiceForm /> #17597

dizel852 · 2022-10-05T09:15:47Z

What

How

Move<ConnectorServiceTypeControl /> outside of the Formik and its Context involves changes in almost all related Source/Destination creation form components.

Reading order(moving from bottom up)

Major

<RequestConnectorModal /> - was part of <ServiceForm />, but actually it relates to <ConnectorServiceTypeContol /> directly. What was done:
- styled components were replaced with CSS modules
- prevent unnecessary prop drilling by combining the <RequestConnectorModal /> and <ConnectorForm/> into one component
<ConnectorServiceTypeContol />. What was done:
- styled components were replaced with CSS modules
- move all utility functions to a separate file (most of the functions are responsible for preparing data )
- move all analytics track functions to useAnalyticsTrackFunctions.tsx file alongside the <ConnectorServiceTypeContol /> component, since they are used in one place.
- add newly refactored <RequestConnectorModal /> and use the new Modal service to control the <RequestConnectorModal /> modal instead of toggling the state in <ServiceForm />
<ServiceForm />. What was done:
- <ConnectorServiceTypeContol /> was moved out on one level higher(outside Formik form)
- remove all unrelated directly components, like <RequestConnectorModal />, <FrequentlyUsedDestinations /> and <StartWithDestination /> on the right layer(<DestinationForm/>)
- extend <ServiceForm /> to support optional render components in the form (<FrequentlyUsedDestinations /> and <StartWithDestination /> will be passed this way)
- render field "serviceType" as null since we don't need to edit this field on UI, but need its data onSubmit action
<FormRoot />. What was done:
- styled components were replaced with CSS modules
<ConnectorCard /> - main Creation/Edit Connector form component, it combines all together. What was done:
- move <ConnectorServiceTypeContol /> here
- extend <ConnectorCard /> to support optional render components in the form (<FrequentlyUsedDestinations /> and <StartWithDestination /> will be passed this way as props)
<DestinationForm /> - and here we make our <ConnectorCard /> specific via props. What was done:
- pass <FrequentlyUsedDestinations /> and <StartWithDestination /> as a props
- move analytics tracking functions to components where they actually use - "Select Connector" was moved to the <ConnectorServiceTypeContol /> component
- remove unnecessary Formik dependencies

Minor

<StartWithDestination /> - was added additional 'template' layer <StartWithDestinationCard />. The <StartWithDestinationCard /> it's just a render template and responsible for rendering the passed props. What was done:
- keep analytics track functions in a separate file alongside with component
- move analytics tracking functions to <StartWithDestination /> and don't mix it with the render template
- remove unnecessary Formik dependencies
<FrequentlyUsedDestinations /> - Same here: new 'template' layer `. What was done:
- keep analytics track functions in a separate file alongside with component
- move analytics tracking functions to <FrequentlyUsedDestinations /> and don't mix it with the render template
- remove unnecessary Formik dependencies
<DestinationForm /> , <DestinationStep />, <SourceForm />, <SourceStep /> - the all had analytics tracking functions which actually was a code duplication. And since they all were tracking the same activity - "Connector selected", this tracking function was moved to a related place - <ConnectorServiceTypeContol />
<TestingConnectionSpinner />. What was done:
- styled components were replaced with CSS modules
<WarningMessage />. What was done:
- styled components were replaced with CSS modules
<ModalBody />. What was done:
- was extended to support style overwrite, since there was an unnecessary scroll

# Conflicts: # airbyte-webapp/src/views/Connector/ServiceForm/components/TestingConnectionSpinner.module.scss # airbyte-webapp/src/views/Connector/ServiceForm/components/TestingConnectionSpinner.tsx

…trol components

- update tests - updates storybook

- move utility functions outside of component - move analytics tracking functions to separate component hook

- update tests - remove test with checking serviceType

…tion is provided

…trol components

edmundito

I really like where this is going. Lots of good changes there. I put comments on areas that could be improved.

In the future, I would have liked to see this change split into separate PRs that change one aspect of the code. The service type change, the analytics changes, and scss refactor done at the same time means that we will need to spend more time testing this before merge to make sure there were no issues.

...-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx

edmundito · 2022-10-10T10:59:41Z

airbyte-webapp/src/views/Connector/RequestConnectorModal/RequestConnectorModal.tsx

+    >
+      {({ setFieldValue }) => (
+        <Form>
+          <ModalBody className={styles.modalBody}>


ModalBody should be outside of the form/formik. Instead it should be

<ModalBody> <Formik> <Form>

Agree. Fixed. But needed to add additional submit handler since the "submit" button is in the ModalFooter (outside the Formik context)

...-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx

edmundito · 2022-10-10T11:17:22Z

...src/views/Connector/ServiceForm/components/StartWithDestination/StartWithDestinationCard.tsx

+          <ConnectorCard
+            icon={icon}
+            releaseStage={releaseStage}
+            connectionName={formatMessage({ id: "destinations.dontHaveYourOwnDestination" })}
+            connectorName={formatMessage({ id: "destinations.startWith" }, { name })}
+            fullWidth
+          />


I wonder if it makes sense to put this back on StartWithDestination and render children here. This component seems good for isolating the card style but looks like the logic is still up in StartWithDestination

I'm not sure I'm quite understanding what the value of this component is. Why is it worse to just have all of this code in StartWithDestination, and all of the styles that are associated with that component in the same SCSS module file?

airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.tsx

...s/Connector/ServiceForm/components/Controls/ConnectorServiceTypeControl/utilityFunctions.tsx

edmundito · 2022-10-10T14:58:49Z

airbyte-webapp/src/pages/OnboardingPage/components/DestinationStep.tsx

@@ -97,6 +87,7 @@ const DestinationStep: React.FC<Props> = ({ onNextStep, onSuccess }) => {
      errorMessage={errorMessage}
      selectedConnectorDefinitionSpecification={destinationDefinitionSpecification}
      isLoading={isLoading}
+      formValues={destinationDefinitionId ? { serviceType: destinationDefinitionId } : undefined}


Would it make more sense to set this prop as serviceType or connectorDefinitionId? and then create the object inside the ConnectorCard?

Figuring out, if can we do it easily...
Since some components use it also

edmundito · 2022-10-10T15:01:00Z

airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.tsx

+          {additionalDropdownComponent}
+        </div>
+      </Card>
+      {intermediateComponent}


This could use a better name as well. It's unclear what intermediateComponent means without having to look at the implementation

additionalBottomComponent - sounds better?

Since this intermediateComponent prop is only used in one place (DestinationForm), and it is just being placed after everything else in the ConnectorCard component, would it maybe make more sense to just remove the prop-drilling and place the StartWithDestination component after the ConnectorCard component in DestinationForm?

Hmm... Yep, you are right - in this case, it's definitely better to move it to the bottom and remove the prop-drilling. 👍

Since we had a talk with Nico and decided not to split the whole ConnectorCard into multiple Card components (leaving the old design) at least for now.
So I will remove the intermediateComponent.

PS.
The reason why I called it intermediateComponent is because of the design: https://www.figma.com/file/8aM4gBoW95whyshI5kwVct/01_06_SOURCES?node-id=405%3A4015

@dizel852 cool, once that change is made then I think this PR looks good to me from my end!

airbyte-webapp/src/views/Connector/ConnectorCard/useAnalyticsTrackFunctions.tsx

edmundito · 2022-10-10T15:05:45Z

airbyte-webapp/src/views/Connector/ServiceForm/ServiceForm.tsx

-        },
+        /* since we use <ConnectorServiceTypeControl/> outside formik form
+           we need to keep the serviceType field in formik, but hide it */
+        component: () => null,


Do we need to define a null component?

Replied below

lmossman

Left some comments. Overall I think these changes look good and bring the ServiceForm closer in line to what we want, so nice job!

There are still some comments from Edmundo and merge conflicts that should be addressed before approval. I agree with his sentiment that these changes would have been easier to test and review if they had been made incrementally in smaller PRs

lmossman · 2022-10-10T22:45:52Z

airbyte-webapp/src/views/Connector/ServiceForm/ServiceForm.tsx

+        /* since we use <ConnectorServiceTypeControl/> outside formik form
+           we need to keep the serviceType field in formik, but hide it */


I'm not quite understanding why we still need to keep the serviceType field here. Why can't it be removed?

I think the idea is that it's automatically part of the values, that will be send to the API later. If that's the case, I'd also still like to see this removed. I think we should just once when sending to the API actually merge the serviceType from the other select into the request, and not have this at all part of Formik.

lmossman · 2022-10-10T22:50:17Z

airbyte-webapp/src/views/Connector/ServiceForm/FormRoot.tsx

@@ -57,15 +42,15 @@ const FormRoot: React.FC<FormRootProps> = ({
  const { resetServiceForm, isLoadingSchema, selectedService, isEditMode, formType } = useServiceForm();

  return (
-    <FormContainer>
+    <Form className={classnames(styles.formContainer, { [styles.emptyContainer]: !selectedConnector })}>


Option 3 sounds the best to me out of the ones you listed

lmossman · 2022-10-10T23:04:05Z

...src/views/Connector/ServiceForm/components/StartWithDestination/StartWithDestinationCard.tsx

+          <ConnectorCard
+            icon={icon}
+            releaseStage={releaseStage}
+            connectionName={formatMessage({ id: "destinations.dontHaveYourOwnDestination" })}
+            connectorName={formatMessage({ id: "destinations.startWith" }, { name })}
+            fullWidth
+          />


I'm not sure I'm quite understanding what the value of this component is. Why is it worse to just have all of this code in StartWithDestination, and all of the styles that are associated with that component in the same SCSS module file?

lmossman · 2022-10-10T23:20:13Z

airbyte-webapp/src/views/Connector/RequestConnectorModal/RequestConnectorModal.tsx

+    >
+      {({ setFieldValue }) => (
+        <Form>
+          <ModalBody className={styles.modalBody}>


Why are we using ModalBody instead of the Modal component?

We use Modal, it's defined in ModalService. And later wraps the modal's content with ModalBody

airbyte/airbyte-webapp/src/hooks/services/Modal/ModalService.tsx

Lines 41 to 57 in 7c4980b

return (

<modalServiceContext.Provider value={service}>

{children}

{modalOptions && (

<Modal

title={modalOptions.title}

size={modalOptions.size}

onClose={modalOptions.preventCancel ? undefined : () => resultSubjectRef.current?.next({ type: "canceled" })}

>

<modalOptions.content

onCancel={() => resultSubjectRef.current?.next({ type: "canceled" })}

onClose={(reason) => resultSubjectRef.current?.next({ type: "closed", reason })}

/>

</Modal>

)}

</modalServiceContext.Provider>

);

…onPage/components/DestinationForm.tsx Co-authored-by: Edmundo Ruiz Ghanem <168664+edmundito@users.noreply.github.com>

# Conflicts: # airbyte-webapp/src/views/Connector/ServiceForm/components/Controls/ConnectorServiceTypeControl/ConnectorServiceTypeControl.tsx # airbyte-webapp/src/views/Connector/ServiceForm/components/StartWithDestination/__snapshots__/StartWithDestination.test.tsx.snap # airbyte-webapp/src/views/Connector/ServiceForm/components/WarningMessage.tsx

dizel852 · 2022-10-12T12:25:21Z

@edmundito @lmossman I will answer here since some of your comments are similar:

1. Remove `serviceType` from `<ServiceForm />`

I completely agree, since we don't edit/set manually we do not need it in form. The reason why I left it, is because FormValues is tightly coupled with the rest functionality:

Since the PR already has a lot of changed files, I suggest making another PR, where I completely and safely remove the ServiceType prop from the Formik form.
WDYT?

Regarding this one: #17597 (comment)
If won't set the null, the serviceType prop will be wrapped with the default form and will be displayed in Form, as editable input with serviceType with its value.

2. `<StartWithDestination />` and `<FrequenlyUsedDestinations />`

I did a try to make components more granular and testable - decoupling logic from view.
Example:

<StartWithDestination>
....preparing data to render....
     <StartWithDestinationCard {...pass data to render}>
</StartWithDestination>

StartWithDestination - become a container, responsible for preparing, calculating, and adding additional handlers like analytics tracking functions.
StartWithDestinationCard - actual template, responsible only for rendering data (dumb component). Easier to test the actual template, and add it to the storybook.

I can revert the changes I've made if you don't prefer this approach.

lmossman · 2022-10-13T00:39:21Z

I suggest making another PR, where I completely and safely remove the ServiceType prop from the Formik form. WDYT?

I think that approach is fine, though looking at some of the files in your screenshot it doesn't seem like many of them would need changes just because you remove serviceType. But if removing that actually does end up being a lot of changes, then I think it's fine to do that in a separate follow-up PR.

StartWithDestination - become a container, responsible for preparing, calculating, and adding additional handlers like analytics tracking functions.
StartWithDestinationCard - actual template, responsible only for rendering data (dumb component). Easier to test the actual template, and add it to the storybook.

I see, I think this makes sense. Especially the storybook comment, I definitely see why having a dumb component with just the formatting logic makes it much easier to have in storybook. So I think I'm happy with this approach

I also had one more comment here: #17597 (comment)

…tiple cards

lmossman

Code LGTM, tested locally and the connector form seems to be working as expected 👍

* remove styled components from FormRoot * refactored WarningMessage component * refactored TestingConnectionSpinner component * fixes after merge * replace styled-components with css modules in ConnectorServiceTypeControl components * extend ModalBody to support style overwrite * refactor RequestConnectorModal using new headlessUi Modal component * - refactor FrequentlyUsedDestinations component - update tests - updates storybook * - refactor StartWithDestination component - update tests - updates storybook * renamed FrequentlyUsedDestinationsCard component * move ConnectorForm to RequestConnectorModal * remove spinner from FrequentlyUsedDestinations component * - refactor ConnectorServiceTypeControl component - move utility functions outside of component - move analytics tracking functions to separate component hook * - refactor ServiceForm component - update tests - remove test with checking serviceType * memoize selectProps in ConnectorServiceTypeControl * simplify getting the namespace type * show FormRoot conditionally - if selectedConnectorDefinitionSpecification is provided * - refactor ConnectorCard component * refactor DestinationForm component * remove styled components from FormRoot * refactored WarningMessage component * refactored TestingConnectionSpinner component * fixes after merge * replace styled-components with css modules in ConnectorServiceTypeControl components * extend ModalBody to support style overwrite * refactor RequestConnectorModal using new headlessUi Modal component * - refactor FrequentlyUsedDestinations component - update tests - updates storybook * - refactor StartWithDestination component - update tests - updates storybook * renamed FrequentlyUsedDestinationsCard component * move ConnectorForm to RequestConnectorModal * remove spinner from FrequentlyUsedDestinations component * - refactor ConnectorServiceTypeControl component - move utility functions outside of component - move analytics tracking functions to separate component hook * - refactor ServiceForm component - update tests - remove test with checking serviceType * memoize selectProps in ConnectorServiceTypeControl * simplify getting the namespace type * show FormRoot conditionally - if selectedConnectorDefinitionSpecification is provided * - refactor ConnectorCard component * refactor DestinationForm component * fixes after rebase * fixed optional onDestinationSelect callbacks * add analyticsTrackFunctions to FrequentlyUsedDestinations component * update tests * fix fullWidth Card issue * fix async/await issue * refactor analytics - Source/Destination connector selected * fix onboarding page - octavia's line * wrap analytics track functions with useCallback * move analytics track functions to separate useAnalyticsTrackFunctions file * rename filename to match the contained component name * extend SectionContainer - do not add margin-bottom if container doesn't have any childs * disable ConnectorServiceTypeControl is form is submitting * fix onbording create source/destination steps * hide form via css if selectedConnector is not present * remove comments * fix e2e tests * fix test * bring back the old design (don't split form on separate cards) * Update airbyte-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx Co-authored-by: Edmundo Ruiz Ghanem <168664+edmundito@users.noreply.github.com> * rename "additionalDropdownComponent" to "additionalSelectorComponent" * rename "formType" arg to "connectorType" in analytics track functions * fix components import * updated test snapshot * update RequestConnectorModal: move Formik inside the ModalBody * fix PR comments: rename utilityFunctions.tsx to utils.tsx * move StartWithDestination component to DestinationForm * remove hiding empty form functionality since we don't split it on multiple cards * update comment regarding the serviceType prop Co-authored-by: Edmundo Ruiz Ghanem <168664+edmundito@users.noreply.github.com>

dizel852 added 21 commits September 22, 2022 23:19

remove styled components from FormRoot

66b3a3a

refactored WarningMessage component

deb98f4

refactored TestingConnectionSpinner component

6a546fa

Merge branch 'master' into vlad/13056-refactor-service-form

ca9a934

# Conflicts: # airbyte-webapp/src/views/Connector/ServiceForm/components/TestingConnectionSpinner.module.scss # airbyte-webapp/src/views/Connector/ServiceForm/components/TestingConnectionSpinner.tsx

fixes after merge

9fdc8a2

Merge branch 'master' into vlad/13056-refactor-service-form

a3ad255

replace styled-components with css modules in ConnectorServiceTypeCon…

c526298

…trol components

extend ModalBody to support style overwrite

bc48fb1

refactor RequestConnectorModal using new headlessUi Modal component

4db15ad

- refactor FrequentlyUsedDestinations component

c20fb7c

- update tests - updates storybook

- refactor StartWithDestination component

c086864

- update tests - updates storybook

renamed FrequentlyUsedDestinationsCard component

4a97bc8

move ConnectorForm to RequestConnectorModal

81df034

remove spinner from FrequentlyUsedDestinations component

79786bf

- refactor ConnectorServiceTypeControl component

8a7753a

- move utility functions outside of component - move analytics tracking functions to separate component hook

- refactor ServiceForm component

1e9d443

- update tests - remove test with checking serviceType

memoize selectProps in ConnectorServiceTypeControl

dce09ce

simplify getting the namespace type

616939c

show FormRoot conditionally - if selectedConnectorDefinitionSpecifica…

a828ab1

…tion is provided

- refactor ConnectorCard component

7cf4da2

refactor DestinationForm component

4681456

github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Oct 5, 2022

dizel852 changed the title ~~🪟 🔧 Refactoring <ServiceForm />~~ 🪟 🔧 WIP: Refactoring <ServiceForm /> Oct 5, 2022

dizel852 added 6 commits October 6, 2022 02:22

remove styled components from FormRoot

e2bf4eb

refactored WarningMessage component

f29f1f0

refactored TestingConnectionSpinner component

ed512ae

fixes after merge

4438348

replace styled-components with css modules in ConnectorServiceTypeCon…

089a4b0

…trol components

extend ModalBody to support style overwrite

86d2afc

timroes requested a review from lmossman October 10, 2022 10:13

edmundito reviewed Oct 10, 2022

View reviewed changes

lmossman reviewed Oct 10, 2022

View reviewed changes

dizel852 and others added 9 commits October 11, 2022 17:24

bring back the old design (don't split form on separate cards)

0502a41

Update airbyte-webapp/src/pages/DestinationPage/pages/CreateDestinati…

8b330b1

…onPage/components/DestinationForm.tsx Co-authored-by: Edmundo Ruiz Ghanem <168664+edmundito@users.noreply.github.com>

rename "additionalDropdownComponent" to "additionalSelectorComponent"

0468cc5

rename "formType" arg to "connectorType" in analytics track functions

ab7b9d8

fix components import

e16de7c

updated test snapshot

6966e7d

update RequestConnectorModal: move Formik inside the ModalBody

4b8f468

fix PR comments: rename utilityFunctions.tsx to utils.tsx

905e604

dizel852 added 5 commits October 13, 2022 21:14

Merge branch 'master' into vlad/13056-refactor-service-form

f183e54

Merge branch 'master' into vlad/13056-refactor-service-form

37ac0e5

move StartWithDestination component to DestinationForm

8a9242b

remove hiding empty form functionality since we don't split it on mul…

f33220c

…tiple cards

update comment regarding the serviceType prop

5964f52

lmossman approved these changes Oct 14, 2022

View reviewed changes

dizel852 merged commit fa38850 into master Oct 17, 2022

dizel852 deleted the vlad/13056-refactor-service-form branch October 17, 2022 12:21

dizel852 mentioned this pull request Oct 17, 2022

🪟 🔧 Remove "serviceType" prop from Formik's formValues (<ServiceForm/> refactoring part 2) #18051

Closed

edmundito mentioned this pull request Oct 17, 2022

feat: move serviceType selection out of serviceForm #14526

Closed

dizel852 mentioned this pull request Oct 19, 2022

🪟 🔧 Move the serviceType prop out from Formik form (<ServiceForm/> refactoring part 2) #18168

Merged

octavia-squidington-iii mentioned this pull request Oct 20, 2022

Bump Airbyte version from 0.40.15 to 0.40.16 #18268

Merged

This was referenced Oct 27, 2022

🪟 🔧 [DRAFT] Refactor ServiceForm and ConnectorCard to move Formik and ServiceFormContext on top level #18229

Closed

Refactor <ConnectorCard /> (<ServiceForm> refactoring part 3) #18553

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🪟 🔧 Refactored <ServiceForm /> #17597

🪟 🔧 Refactored <ServiceForm /> #17597

dizel852 commented Oct 5, 2022 •

edited

Loading

edmundito left a comment

edmundito Oct 10, 2022

dizel852 Oct 12, 2022 •

edited

Loading

edmundito Oct 10, 2022

lmossman Oct 10, 2022

edmundito Oct 10, 2022

dizel852 Oct 12, 2022

edmundito Oct 10, 2022

dizel852 Oct 11, 2022

lmossman Oct 13, 2022

dizel852 Oct 13, 2022

lmossman Oct 13, 2022

edmundito Oct 10, 2022

dizel852 Oct 13, 2022 •

edited

Loading

lmossman left a comment •

edited

Loading

lmossman Oct 10, 2022

timroes Oct 13, 2022

lmossman Oct 10, 2022

lmossman Oct 10, 2022

lmossman Oct 10, 2022

dizel852 Oct 11, 2022 •

edited

Loading

dizel852 commented Oct 12, 2022 •

edited

Loading

lmossman commented Oct 13, 2022 •

edited

Loading

lmossman left a comment

		/* since we use <ConnectorServiceTypeControl/> outside formik form
		we need to keep the serviceType field in formik, but hide it */

	return (
	<modalServiceContext.Provider value={service}>
	{children}
	{modalOptions && (
	<Modal
	title={modalOptions.title}
	size={modalOptions.size}
	onClose={modalOptions.preventCancel ? undefined : () => resultSubjectRef.current?.next({ type: "canceled" })}
	>
	<modalOptions.content
	onCancel={() => resultSubjectRef.current?.next({ type: "canceled" })}
	onClose={(reason) => resultSubjectRef.current?.next({ type: "closed", reason })}
	/>
	</Modal>
	)}
	</modalServiceContext.Provider>
	);

🪟 🔧 Refactored <ServiceForm /> #17597

🪟 🔧 Refactored <ServiceForm /> #17597

Conversation

dizel852 commented Oct 5, 2022 • edited Loading

What

How

Reading order(moving from bottom up)

Major

Minor

edmundito left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dizel852 Oct 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dizel852 Oct 13, 2022 • edited Loading

Choose a reason for hiding this comment

lmossman left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dizel852 Oct 11, 2022 • edited Loading

Choose a reason for hiding this comment

dizel852 commented Oct 12, 2022 • edited Loading

1. Remove serviceType from <ServiceForm />

2. <StartWithDestination /> and <FrequenlyUsedDestinations />

lmossman commented Oct 13, 2022 • edited Loading

lmossman left a comment

Choose a reason for hiding this comment

dizel852 commented Oct 5, 2022 •

edited

Loading

dizel852 Oct 12, 2022 •

edited

Loading

dizel852 Oct 13, 2022 •

edited

Loading

lmossman left a comment •

edited

Loading

dizel852 Oct 11, 2022 •

edited

Loading

dizel852 commented Oct 12, 2022 •

edited

Loading

1. Remove `serviceType` from `<ServiceForm />`

2. `<StartWithDestination />` and `<FrequenlyUsedDestinations />`

lmossman commented Oct 13, 2022 •

edited

Loading