Code

🪟 🔧 Refactored <ServiceForm />#17597

Code

Merged

dizel852 merged 77 commits intomasterairbytehq/airbyte:masterfrom vlad/13056-refactor-service-formairbytehq/airbyte:vlad/13056-refactor-service-formCopy head branch name to clipboardOct 17, 2022

+906-872

Commits

Commits on Sep 22, 2022

• remove styled components from FormRoot

  dizel852

  committed
  66b3a3a

  Copy full SHA for 66b3a3a

• refactored WarningMessage component

  dizel852

  committed
  deb98f4

  Copy full SHA for deb98f4

Commits on Sep 23, 2022

• refactored TestingConnectionSpinner component

  dizel852

  committed
  6a546fa

  Copy full SHA for 6a546fa

Commits on Sep 29, 2022

• Merge branch 'master' into vlad/13056-refactor-service-form

  Show description for ca9a934
  dizel852

  committed
  ca9a934

  Copy full SHA for ca9a934

• fixes after merge

  dizel852

  committed
  9fdc8a2

  Copy full SHA for 9fdc8a2

• Merge branch 'master' into vlad/13056-refactor-service-form

  dizel852

  committed
  a3ad255

  Copy full SHA for a3ad255

Commits on Oct 2, 2022

• replace styled-components with css modules in ConnectorServiceTypeControl components

  dizel852

  committed
  c526298

  Copy full SHA for c526298

Commits on Oct 3, 2022

• extend ModalBody to support style overwrite

  dizel852

  committed
  bc48fb1

  Copy full SHA for bc48fb1

• refactor RequestConnectorModal using new headlessUi Modal component

  dizel852

  committed
  4db15ad

  Copy full SHA for 4db15ad

• - refactor FrequentlyUsedDestinations component

  Show description for c20fb7c
  dizel852

  committed
  c20fb7c

  Copy full SHA for c20fb7c

• - refactor StartWithDestination component

  Show description for c086864
  dizel852

  committed
  c086864

  Copy full SHA for c086864

• renamed FrequentlyUsedDestinationsCard component

  dizel852

  committed
  4a97bc8

  Copy full SHA for 4a97bc8

• move ConnectorForm to RequestConnectorModal

  dizel852

  committed
  81df034

  Copy full SHA for 81df034

• remove spinner from FrequentlyUsedDestinations component

  dizel852

  committed
  79786bf

  Copy full SHA for 79786bf

• - refactor ConnectorServiceTypeControl component

  Show description for 8a7753a
  dizel852

  committed
  8a7753a

  Copy full SHA for 8a7753a

• - refactor ServiceForm component

  Show description for 1e9d443
  dizel852

  committed
  1e9d443

  Copy full SHA for 1e9d443

• memoize selectProps in ConnectorServiceTypeControl

  dizel852

  committed
  dce09ce

  Copy full SHA for dce09ce

• simplify getting the namespace type

  dizel852

  committed
  616939c

  Copy full SHA for 616939c

Commits on Oct 5, 2022

• show FormRoot conditionally - if selectedConnectorDefinitionSpecification is provided

  dizel852

  committed
  a828ab1

  Copy full SHA for a828ab1

• - refactor ConnectorCard component

  dizel852

  committed
  7cf4da2

  Copy full SHA for 7cf4da2

• refactor DestinationForm component

  dizel852

  committed
  4681456

  Copy full SHA for 4681456

• remove styled components from FormRoot

  dizel852

  committed
  e2bf4eb

  Copy full SHA for e2bf4eb

• refactored WarningMessage component

  dizel852

  committed
  f29f1f0

  Copy full SHA for f29f1f0

• refactored TestingConnectionSpinner component

  dizel852

  committed
  ed512ae

  Copy full SHA for ed512ae

• fixes after merge

  dizel852

  committed
  4438348

  Copy full SHA for 4438348

• replace styled-components with css modules in ConnectorServiceTypeControl components

  dizel852

  committed
  089a4b0

  Copy full SHA for 089a4b0

• extend ModalBody to support style overwrite

  dizel852

  committed
  86d2afc

  Copy full SHA for 86d2afc

• refactor RequestConnectorModal using new headlessUi Modal component

  dizel852

  committed
  79c6349

  Copy full SHA for 79c6349

• - refactor FrequentlyUsedDestinations component

  Show description for 131e348
  dizel852

  committed
  131e348

  Copy full SHA for 131e348

• - refactor StartWithDestination component

  Show description for 8da7ea1
  dizel852

  committed
  8da7ea1

  Copy full SHA for 8da7ea1

• renamed FrequentlyUsedDestinationsCard component

  dizel852

  committed
  b5c5d69

  Copy full SHA for b5c5d69

• move ConnectorForm to RequestConnectorModal

  dizel852

  committed
  a9836ea

  Copy full SHA for a9836ea

• remove spinner from FrequentlyUsedDestinations component

  dizel852

  committed
  6eb56f7

  Copy full SHA for 6eb56f7

• - refactor ConnectorServiceTypeControl component

  Show description for f7f9321
  dizel852

  committed
  f7f9321

  Copy full SHA for f7f9321

• - refactor ServiceForm component

  Show description for 33f193a
  dizel852

  committed
  33f193a

  Copy full SHA for 33f193a

• memoize selectProps in ConnectorServiceTypeControl

  dizel852

  committed
  25f2b0a

  Copy full SHA for 25f2b0a

• simplify getting the namespace type

  dizel852

  committed
  c3b28f8

  Copy full SHA for c3b28f8

• show FormRoot conditionally - if selectedConnectorDefinitionSpecification is provided

  dizel852

  committed
  12649e9

  Copy full SHA for 12649e9

• - refactor ConnectorCard component

  dizel852

  committed
  318c0a0

  Copy full SHA for 318c0a0

• refactor DestinationForm component

  dizel852

  committed
  ec032bc

  Copy full SHA for ec032bc

Commits on Oct 6, 2022

• fixes after rebase

  dizel852

  committed
  7f5bf4c

  Copy full SHA for 7f5bf4c

• fixed optional onDestinationSelect callbacks

  dizel852

  committed
  0d955b5

  Copy full SHA for 0d955b5

• add analyticsTrackFunctions to FrequentlyUsedDestinations component

  dizel852

  committed
  ca87165

  Copy full SHA for ca87165

• Merge branch 'test-rebase-with-master' into vlad/13056-refactor-service-form

  Show description for b5d06d5
  dizel852

  committed
  b5d06d5

  Copy full SHA for b5d06d5

• update tests

  dizel852

  committed
  9d984fd

  Copy full SHA for 9d984fd

• fix fullWidth Card issue

  dizel852

  committed
  225e0f0

  Copy full SHA for 225e0f0

• fix async/await issue

  dizel852

  committed
  d02d949

  Copy full SHA for d02d949

• refactor analytics - Source/Destination connector selected

  dizel852

  committed
  eee568e

  Copy full SHA for eee568e

• fix onboarding page - octavia's line

  dizel852

  committed
  4edb85f

  Copy full SHA for 4edb85f

• Merge branch 'master' into vlad/13056-refactor-service-form

  dizel852

  committed
  83ff9a7

  Copy full SHA for 83ff9a7

Commits on Oct 7, 2022

• Merge branch 'master' into vlad/13056-refactor-service-form

  dizel852

  committed
  cc0a05f

  Copy full SHA for cc0a05f

• Merge branch 'master' into vlad/13056-refactor-service-form

  Show description for 235355c
  dizel852

  committed
  235355c

  Copy full SHA for 235355c

• wrap analytics track functions with useCallback

  dizel852

  committed
  714fd60

  Copy full SHA for 714fd60

• move analytics track functions to separate useAnalyticsTrackFunctions file

  dizel852

  committed
  26ce62b

  Copy full SHA for 26ce62b

• rename filename to match the contained component name

  dizel852

  committed
  0d0a8e7

  Copy full SHA for 0d0a8e7

Commits on Oct 8, 2022

• extend SectionContainer - do not add margin-bottom if container doesn't have any childs

  dizel852

  committed
  5441f17

  Copy full SHA for 5441f17

Commits on Oct 9, 2022

• disable ConnectorServiceTypeControl is form is submitting

  dizel852

  committed
  18cc3a6

  Copy full SHA for 18cc3a6

• fix onbording create source/destination steps

  dizel852

  committed
  26af0ad

  Copy full SHA for 26af0ad

• hide form via css if selectedConnector is not present

  dizel852

  committed
  b83b8d9

  Copy full SHA for b83b8d9

• remove comments

  dizel852

  committed
  b868779

  Copy full SHA for b868779

• fix e2e tests

  dizel852

  committed
  aee9076

  Copy full SHA for aee9076

Commits on Oct 10, 2022

• Merge branch 'master' into vlad/13056-refactor-service-form

  dizel852

  authored
  ac17412

  Copy full SHA for ac17412

• fix test

  dizel852

  committed
  bd4a291

  Copy full SHA for bd4a291

Commits on Oct 11, 2022

• bring back the old design (don't split form on separate cards)

  dizel852

  committed
  0502a41

  Copy full SHA for 0502a41

• Update airbyte-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx

  Show description for 8b330b1
  

  dizel852

  and

  edmundito

  authored
  8b330b1

  Copy full SHA for 8b330b1

• rename "additionalDropdownComponent" to "additionalSelectorComponent"

  dizel852

  committed
  0468cc5

  Copy full SHA for 0468cc5

• rename "formType" arg to "connectorType" in analytics track functions

  dizel852

  committed
  ab7b9d8

  Copy full SHA for ab7b9d8

Commits on Oct 12, 2022

• Merge branch 'master' into vlad/13056-refactor-service-form

  Show description for 00b5099
  dizel852

  committed
  00b5099

  Copy full SHA for 00b5099

• fix components import

  dizel852

  committed
  e16de7c

  Copy full SHA for e16de7c

• updated test snapshot

  dizel852

  committed
  6966e7d

  Copy full SHA for 6966e7d

• update RequestConnectorModal: move Formik inside the ModalBody

  dizel852

  committed
  4b8f468

  Copy full SHA for 4b8f468

• fix PR comments: rename utilityFunctions.tsx to utils.tsx

  dizel852

  committed
  905e604

  Copy full SHA for 905e604

Commits on Oct 13, 2022

• Merge branch 'master' into vlad/13056-refactor-service-form

  dizel852

  committed
  f183e54

  Copy full SHA for f183e54

Commits on Oct 14, 2022

• Merge branch 'master' into vlad/13056-refactor-service-form

  dizel852

  committed
  37ac0e5

  Copy full SHA for 37ac0e5

• move StartWithDestination component to DestinationForm

  dizel852

  committed
  8a9242b

  Copy full SHA for 8a9242b

• remove hiding empty form functionality since we don't split it on multiple cards

  dizel852

  committed
  f33220c

  Copy full SHA for f33220c

• update comment regarding the serviceType prop

  dizel852

  committed
  5964f52

  Copy full SHA for 5964f52