-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate update/delete custom definitions to regular update/delete definitions #19669
Labels
Comments
Refining notes:
|
davinchia
pushed a commit
that referenced
this issue
Nov 23, 2022
Closes #19637 PR that introduced this bug was a precision revert of another issue: #19627 This PR removes the createSourceDefinition() and createDestinationDefinition() methods in favor of the new createCustomSourceDefinition() and createCustomDestinationDefinition() methods. createSourceDefinition() and createDestinationDefinition() are to be deprecated. This PR does not address updating custom connectors. There is a backend issue for fixing this behavior here: #19669
I was doing a PR to implement custom definitions, so as far as I know, octavia do not call it yet. My implementation is using the endpoints with the "custom" prefix airbyte/octavia-cli/octavia_cli/apply/resources.py Lines 872 to 898 in 75c66a0
|
SofiiaZaitseva
pushed a commit
that referenced
this issue
Nov 24, 2022
Closes #19637 PR that introduced this bug was a precision revert of another issue: #19627 This PR removes the createSourceDefinition() and createDestinationDefinition() methods in favor of the new createCustomSourceDefinition() and createCustomDestinationDefinition() methods. createSourceDefinition() and createDestinationDefinition() are to be deprecated. This PR does not address updating custom connectors. There is a backend issue for fixing this behavior here: #19669
Closing this as a duplicate in favor of #19670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FE should use the same API when user wants to update or delete their source or destination definition.
This ticket requires to consolidate 4 custom APIs into the original API (FE will use the one without
custom
in it, such as updateSourceDefinition)Also as part of the effort we should remove the legacy creation path to avoid misuse:
POST /v1/source_definitions/create
POST /v1/destination_definitions/create
The text was updated successfully, but these errors were encountered: