Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show refresh notification when backend is outdated #19767

Closed
timroes opened this issue Nov 23, 2022 · 4 comments · Fixed by #22480
Closed

Show refresh notification when backend is outdated #19767

timroes opened this issue Nov 23, 2022 · 4 comments · Fixed by #22480
Assignees
Labels
area/frontend Related to the Airbyte webapp team/compose

Comments

@timroes
Copy link
Collaborator

timroes commented Nov 23, 2022

We ever so often see users running into the following problem: they have their Airbyte webapp opened in the browser for very long time. We update the backend during that time. When they now try to navigate and load a JS/CSS chunk they haven't loaded beforehand this chunk no longer exists on the server, and loading the chunk will just fail, which usually just causes weird errors in the UI. We should show a toast notification to the user if the backend got updated and they need to refresh the page.

For that we could leverage the already existing v1/health call. This could return as part of it's response a custom hash for that server version, and we compare it against the one the frontend code still knows. If they differ show a toast notification asking to refrsh the page.

Why not send the version as part of the response. Sending out versions that the server is, is usually flagged during SOC2 audits as giving out too much information about the system. While we anyway have the version already in the FE, this would kind of not add any new information, but we should still try to not that route so we can later remove versions altogether from the (cloud) product. Any uniquely generated hash would be enough.

@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@krishnaglick
Copy link
Contributor

This should be done after #18631 is completed

@andyjih
Copy link
Contributor

andyjih commented Dec 8, 2022

@krishnaglick It looks like #18631 is done-- closing this issue, but let me know if it should still be open!

@andyjih andyjih closed this as completed Dec 8, 2022
@krishnaglick
Copy link
Contributor

@krishnaglick It looks like #18631 is done-- closing this issue, but let me know if it should still be open!

Poor phrasing on my part! I meant this work should be started after #18631 is finished :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/compose
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants