Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Toast component design #18631

Closed
edmundito opened this issue Oct 28, 2022 · 1 comment · Fixed by #19980
Closed

Update Toast component design #18631

edmundito opened this issue Oct 28, 2022 · 1 comment · Fixed by #19980
Assignees
@dizel852
Labels
area/frontend Related to the Airbyte webapp team/platform-move ui/components

Comments

@edmundito
Copy link
Contributor

edmundito commented Oct 28, 2022 •
edited
Loading

Update the Toast component design to match the new design in Figma:

https://www.figma.com/file/gMNRYVJav25pdsoxAyW7Qp/00_01_WEB-APP-LIBRARIES?node-id=1475%3A2667

  • Ensure that the toast looks good as expected in areas where it's being used
  • Areas that use a title and description should consolidate to just using the description
  • Reduce the bottom margin of the page ($spacing-page-bottom in scss) to be enough for the toast + Intercom badge (>= 88px) - Design
@edmundito edmundito added area/frontend Related to the Airbyte webapp ui/components labels Oct 28, 2022
@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@harshithmullapudi harshithmullapudi mentioned this issue Nov 10, 2022
Closed
@krishnaglick krishnaglick mentioned this issue Nov 23, 2022
Closed
@edmundito edmundito mentioned this issue Nov 28, 2022
Closed
1 task
@dizel852 dizel852 mentioned this issue Dec 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dizel852 dizel852

Labels
area/frontend Related to the Airbyte webapp team/platform-move ui/components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪟 🎨 Update toast design airbytehq/airbyte
4 participants
@edmundito @harshithmullapudi @dizel852 @octavia-squidington-iv