-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🎨 Update toast design #19980
🪟 🎨 Update toast design #19980
Conversation
❓ Just to clarify: chatted with @Upmitt , and we have a design for "errored warning" and "grey info" toasts. ❓ One more clarifications is needed:
Do we need to reduce or increase? Atm we have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a review and posted a few notes.
I will follow up with you about the positioning and the margin issue.
I tried stress testing the toast content and looks like it may nee more work for cases when there's a lot of text:
- Should the text be centered?
- Should the icon be vertically aligned?
- Should the icon and the button protect their width?
@dizel852 for the bottom spacing: Should be 27 px from the bottom instead of 49 as shown in the example Figma:
|
We can just change the toast bottom margin without changing the |
Fixed all the comments. Ready for another review. |
@dizel852 I believe we're not using intercom for banners anymore so we could maybe remove the page bottom padding (or make it smaller). Let me check that beginning of next week and get back to you for this. |
😮 Oh, didn't know that. Okay, looking forward to your reply 👍 |
This reverts commit 6c72ace.
set baseline as flex-start
Fixes and updates:
Chatted with @Upmitt regarding toast behavior and some cases:
Toast behavior examples from @Upmitt: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor details 🔍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have any comments that others have not covered!
Tested on chromatic and tried out a few toasts locally. |
What
Resolves #18631
Closes #19277
Design:
https://www.figma.com/file/gMNRYVJav25pdsoxAyW7Qp/00_01_WEB-APP-LIBRARIES?node-id=1475%3A2667&t=SvkHvP2U7YBoxfkU-0
How
Adds new Toast design + update Notification Service interface + update storybook
Types were added:
Notification examples: