Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector form: Improve logs rendering on failing connection test #20238

Closed
flash1293 opened this issue Dec 8, 2022 · 2 comments · Fixed by #20951
Closed

Connector form: Improve logs rendering on failing connection test #20238

flash1293 opened this issue Dec 8, 2022 · 2 comments · Fixed by #20951
Assignees

Comments

@flash1293
Copy link
Contributor

With advanced mode enabled, the logs from the connection test job are shown below the form together with the error message:
Screenshot 2022-12-08 at 17 19 15

This UI is confusing users because it looks like it failed and worked at the same time. By replacing the standard collapsable with a more subtle "Show logs" button, this UI can be cleaned up. In this case it also makes sense to always show this button even in non-advanced mode.

@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@flash1293
Copy link
Contributor Author

Pending for review, but we focused on the connector builder UI PRs for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants