🪟🎨 Connector form: Improve logs look and feel #20951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
lmossman
approved these changes
Jan 6, 2023
airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.tsx
Outdated
Show resolved
Hide resolved
| <Button | ||
| variant="secondary" | ||
| onClick={() => { | ||
| setLogsVisible(!logsVisible); |
There was a problem hiding this comment.
nit
Suggested change
| setLogsVisible(!logsVisible); | |
| setLogsVisible((prevLogsVisible) => !prevLogsVisible); |
| {job && (advancedMode || !job.succeeded) && <JobItem job={job} />} | ||
| {job && ( | ||
| <div className={styles.connectionTestLogs}> | ||
| <Button |
There was a problem hiding this comment.
It feels like it may make more sense to use an expandable section here rather than a Button, similar to how the BuilderOptional component looks.
Since this button is just showing/hiding additional info, using the faAngleRight / faAngleDown icon next to some text that just says Connection test logs feels like a more natural UX. What do you think?
There was a problem hiding this comment.
Agreed, changed the button to look like this:
added 8 commits
January 6, 2023 13:26
…rbyte into flash1293/improve-logs-view
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
* improve logs look and feel in connector form * add button to toggle * lokk and feel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20238
What
Improves the look of the logs in the connector form.
Old:
New:
How
JobItemwrapper and useJobLogsdirectly - as there is only ever a single entry it doesn't make sense to wrap it into an accordion which looks like a list entryDrive-by fix
In the old implementation there was a weird edge case:
This PR is clearing out the log when the connector is re-tested
Also fixes some inconsistent spacing between components. The whole connector form controls should be cleaned up, but that will be a separate PR.