Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector form: Refactor form controls and improve UX #20967

Closed
flash1293 opened this issue Jan 3, 2023 · 0 comments · Fixed by #21698
Closed

Connector form: Refactor form controls and improve UX #20967

flash1293 opened this issue Jan 3, 2023 · 0 comments · Fixed by #21698
Assignees
Labels

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jan 3, 2023

The controls part of the connector form needs to be refactored in a bunch of ways:

  • Remove leftover styled components
  • Get rid of hardcoded pixel values for sizing (instead rely on flexbox layout)
  • Restructure component hierarchy and props better to capture all different cases

Right now for the edit case there are two buttons: "Retest source" and "Save changes and test". The former one always tests the last saved version even if there have been changes to the form which is very confusing. This should be simplified to only show a single button - if there are no changes to the form, it says "Retest source", if there are changes to the form it says "Save changes and test" and acts accordingly.

In the source or destination create pages, the submit button is placed inside the card:

image.png

The change proposed is to move the button outside of the card to match the current design:
image.png

Prototype:
https://www.figma.com/proto/mFVUWYYjDm5zz6FFx8hTP6/FORMS-FIELDS?page-id=1%3A4&node-id=301%3A10567&viewport=606%2C64%2C0.16&scaling=min-zoom&starting-point-node-id=301%3A10567

In the source settings, the save and delete buttons also move. See in design:
https://www.figma.com/file/8aM4gBoW95whyshI5kwVct/01_06_SOURCES?node-id=222%3A2479

@flash1293 flash1293 changed the title Connector form: Refactor form controls Connector form: Refactor form controls and improve UX Jan 5, 2023
@flash1293 flash1293 added type/enhancement New feature or request and removed technical-debt issues to fix code smell labels Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant