Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dup] Move connector create/save button outside of the card #16469

Closed
Tracked by #14247
edmundito opened this issue Sep 8, 2022 · 2 comments
Closed
Tracked by #14247

[Dup] Move connector create/save button outside of the card #16469

edmundito opened this issue Sep 8, 2022 · 2 comments
Labels
area/frontend Related to the Airbyte webapp team/extensibility

Comments

@edmundito
Copy link
Contributor

edmundito commented Sep 8, 2022 •
edited
Loading

In the source or destination create pages, the submit button is placed inside the card:

image.png

The change proposed is to move the button outside of the card to match the current design:
image.png

Prototype:
https://www.figma.com/proto/mFVUWYYjDm5zz6FFx8hTP6/FORMS-FIELDS?page-id=1%3A4&node-id=301%3A10567&viewport=606%2C64%2C0.16&scaling=min-zoom&starting-point-node-id=301%3A10567

In the source settings, the save and delete buttons also move. See in design:
https://www.figma.com/file/8aM4gBoW95whyshI5kwVct/01_06_SOURCES?node-id=222%3A2479
@edmundito edmundito added the area/frontend Related to the Airbyte webapp label Sep 8, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@YatsukBogdan1 YatsukBogdan1 self-assigned this Sep 12, 2022
@edmundito edmundito mentioned this issue Oct 13, 2022
Closed
4 tasks
@YatsukBogdan1 YatsukBogdan1 mentioned this issue Oct 20, 2022
Closed
@YatsukBogdan1 YatsukBogdan1 mentioned this issue Nov 7, 2022
Closed
@edmundito
Copy link
Contributor Author

Replaced by #20967 - The extensibility team will take over this feature.

@edmundito edmundito closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2023
@edmundito edmundito changed the title Move connector create/save button outside of the card [Dup] Move connector create/save button outside of the card Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp team/extensibility
Projects
None yet
Milestone
No milestone
3 participants
@edmundito @YatsukBogdan1 @octavia-squidington-iii