🪟 🔧 Refactor ConnectorForm Card component usage #19099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
timroes
reviewed
Nov 7, 2022
Comment on lines
12
to
26
| const DeleteBlockComponent = styled(Card)` | ||
| margin-top: 12px; | ||
| padding: 19px 20px 20px; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| `; | ||
|
|
||
| const Text = styled.div` | ||
| margin-left: 20px; | ||
| font-size: 11px; | ||
| line-height: 13px; | ||
| color: ${({ theme }) => theme.greyColor40}; | ||
| white-space: pre-line; | ||
| `; |
There was a problem hiding this comment.
Since this is new code, this should be SASS and not styled components.
timroes
reviewed
Nov 7, 2022
| @@ -0,0 +1,3 @@ | |||
| import DeleteBlock from "./DeleteBlock"; | |||
|
|
|||
| export default DeleteBlock; | |||
There was a problem hiding this comment.
We should not use default imports for new components anymore.
…cture # Conflicts: # airbyte-webapp/src/views/Connector/ConnectorForm/FormRoot.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #16469. This is a new PR that uses less radical changes to
ConnectorForm. Initial PR #18229How
This PR proposes changes to
ConnectorFormthat removes a single bigCardcomponent and uses two smallerCards, one wraps theConnectorDefinitionTypeControlcomponent, and another wrapsFormRoot. This structure allows us to move actions buttons out of theCardcomponent, without significant changes to ConnectorForm