Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Gitlab: Add undeclared columns to spec #24555

Closed
erohmensing opened this issue Mar 27, 2023 · 1 comment
Closed

Source Gitlab: Add undeclared columns to spec #24555

erohmensing opened this issue Mar 27, 2023 · 1 comment
Assignees

Comments

@erohmensing
Copy link
Contributor

What

In this PR, BasicReadTest.test_read test in the Connector Acceptance Tests was updated to fail if the connector produces
stream records which contain columns that haven't been declared in the spec.

Gitlab currently fails the updated test. Its acceptance-test-config.yml was edited with the
fail_on_extra_columns: false parameter in this PR in order to avoid this change from making the connector fail CAT.

We want to add the undeclared columns to the spec.

How this will help:

  • Column selection is currently blocked for connectors that don't declare all columns that they pass. This
    is because turning on column selection will stop these undeclared columns from being sent, when they were
    previously being sent. Doing this allows us to enable column selection for Gitlab!
  • Users will better understand the shape of the data they'll receive, since the columns will match the spec.

How

The following descriptions of streams that pass undeclared columns come from results of the failed connector acceptance test:

columns.txt:./source-gitlab-2209-2023-03-26T03:22:30.1873897Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:2210:2023-03-26T03:22:30.1875875Z Additional properties are not allowed ('marked_for_deletion_on', 'membership_lock', 'ip_restriction_ranges', 'prevent_sharing_groups_outside_hierarchy', 'wiki_access_level' were unexpected)
columns.txt:./source-gitlab-2309-2023-03-26T03:22:30.2055846Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:2310:2023-03-26T03:22:30.2064797Z Additional properties are not allowed ('merge_commit_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'feature_flags_access_level', 'keep_latest_artifact', 'releases_access_level', 'runner_token_expiration_interval', 'ci_job_token_scope_enabled', 'ci_opt_in_jwt', 'ci_separated_caches', 'import_type', 'security_and_compliance_access_level', 'enforce_auth_checks_on_uploads', 'group_runners_enabled', 'container_registry_access_level', 'environments_access_level', 'squash_option', 'requirements_access_level', 'squash_commit_template', 'import_url', 'issue_branch_template', 'monitor_access_level' were unexpected)
columns.txt:./source-gitlab-2630-2023-03-26T03:22:30.2389935Z The epics stream has the following schema errors:
columns.txt:./source-gitlab:2631:2023-03-26T03:22:30.2391293Z Additional properties are not allowed ('color', 'text_color', 'due_date_from_milestones', 'web_edit_url', '_links', 'parent_iid', 'start_date_from_milestones' were unexpected)
columns.txt:./source-gitlab-2711-2023-03-26T03:22:30.2436557Z The epic_issues stream has the following schema errors:
columns.txt:./source-gitlab:2712:2023-03-26T03:22:30.2437742Z Additional properties are not allowed ('severity', 'references', 'task_status', 'iteration', 'closed_by', 'service_desk_reply_to', 'blocking_issues_count', 'task_completion_status', 'moved_to_id', 'epic_iid', 'merge_requests_count', 'issue_type', 'epic', 'relative_position', 'type', 'has_tasks' were unexpected)
columns.txt:./source-gitlab-2807-2023-03-26T03:22:30.2484773Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:2808:2023-03-26T03:22:30.2485501Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-2853-2023-03-26T03:22:30.2524799Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:2854:2023-03-26T03:22:30.2525336Z Additional properties are not allowed ('severity' was unexpected)
columns.txt:./source-gitlab-2948-2023-03-26T03:22:30.2570406Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:2949:2023-03-26T03:22:30.2571010Z Additional properties are not allowed ('erased_at', 'failure_reason', 'project' were unexpected)
columns.txt:./source-gitlab-3012-2023-03-26T03:22:30.2599129Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:3013:2023-03-26T03:22:30.2599745Z Additional properties are not allowed ('created_by', 'membership_state' were unexpected)
columns.txt:./source-gitlab-3051-2023-03-26T03:22:30.2616370Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:3052:2023-03-26T03:22:30.2617023Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-3084-2023-03-26T03:22:30.2631768Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:3085:2023-03-26T03:22:30.2632513Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-3202-2023-03-26T03:22:30.2689716Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:3203:2023-03-26T03:22:30.2690208Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-3379-2023-03-26T03:22:30.2735881Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:3380:2023-03-26T03:22:30.2736190Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-3409-2023-03-26T03:22:30.2742846Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:3410:2023-03-26T03:22:30.2743154Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-3571-2023-03-26T03:22:30.2895047Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:3572:2023-03-26T03:22:30.2895413Z Additional properties are not allowed ('membership_lock', 'wiki_access_level' were unexpected)
columns.txt:./source-gitlab-3664-2023-03-26T03:22:30.2931376Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:3665:2023-03-26T03:22:30.2932824Z Additional properties are not allowed ('merge_commit_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'feature_flags_access_level', 'keep_latest_artifact', 'releases_access_level', 'runner_token_expiration_interval', 'ci_job_token_scope_enabled', 'ci_opt_in_jwt', 'ci_separated_caches', 'import_type', 'security_and_compliance_access_level', 'enforce_auth_checks_on_uploads', 'group_runners_enabled', 'container_registry_access_level', 'environments_access_level', 'squash_option', 'requirements_access_level', 'squash_commit_template', 'import_url', 'issue_branch_template', 'monitor_access_level' were unexpected)
columns.txt:./source-gitlab-3984-2023-03-26T03:22:30.3020401Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:3985:2023-03-26T03:22:30.3020757Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-4030-2023-03-26T03:22:30.3032620Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:4031:2023-03-26T03:22:30.3032918Z Additional properties are not allowed ('severity' was unexpected)
columns.txt:./source-gitlab-4125-2023-03-26T03:22:30.3055462Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:4126:2023-03-26T03:22:30.3055836Z Additional properties are not allowed ('erased_at', 'failure_reason', 'project' were unexpected)
columns.txt:./source-gitlab-4189-2023-03-26T03:22:30.3070877Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:4190:2023-03-26T03:22:30.3071324Z Additional properties are not allowed ('created_by', 'membership_state' were unexpected)
columns.txt:./source-gitlab-4228-2023-03-26T03:22:30.3079837Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:4229:2023-03-26T03:22:30.3080151Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-4261-2023-03-26T03:22:30.3087192Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:4262:2023-03-26T03:22:30.3087620Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-4379-2023-03-26T03:22:30.3115207Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:4380:2023-03-26T03:22:30.3115630Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-4556-2023-03-26T03:22:30.3158402Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:4557:2023-03-26T03:22:30.3158711Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-4586-2023-03-26T03:22:30.3165046Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:4587:2023-03-26T03:22:30.3165358Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-4744-2023-03-26T03:22:30.3349241Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:4745:2023-03-26T03:22:30.3349788Z Additional properties are not allowed ('marked_for_deletion_on', 'membership_lock', 'ip_restriction_ranges', 'prevent_sharing_groups_outside_hierarchy', 'wiki_access_level' were unexpected)
columns.txt:./source-gitlab-4844-2023-03-26T03:22:30.3373480Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:4845:2023-03-26T03:22:30.3374930Z Additional properties are not allowed ('merge_commit_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'feature_flags_access_level', 'keep_latest_artifact', 'releases_access_level', 'runner_token_expiration_interval', 'ci_job_token_scope_enabled', 'ci_opt_in_jwt', 'ci_separated_caches', 'import_type', 'security_and_compliance_access_level', 'enforce_auth_checks_on_uploads', 'group_runners_enabled', 'container_registry_access_level', 'environments_access_level', 'squash_option', 'requirements_access_level', 'squash_commit_template', 'import_url', 'issue_branch_template', 'monitor_access_level' were unexpected)
columns.txt:./source-gitlab-5165-2023-03-26T03:22:30.3460389Z The epics stream has the following schema errors:
columns.txt:./source-gitlab:5166:2023-03-26T03:22:30.3460987Z Additional properties are not allowed ('color', 'text_color', 'due_date_from_milestones', 'web_edit_url', '_links', 'parent_iid', 'start_date_from_milestones' were unexpected)
columns.txt:./source-gitlab-5246-2023-03-26T03:22:30.3479491Z The epic_issues stream has the following schema errors:
columns.txt:./source-gitlab:5247:2023-03-26T03:22:30.3480275Z Additional properties are not allowed ('severity', 'references', 'task_status', 'iteration', 'closed_by', 'service_desk_reply_to', 'blocking_issues_count', 'task_completion_status', 'moved_to_id', 'epic_iid', 'merge_requests_count', 'issue_type', 'epic', 'relative_position', 'type', 'has_tasks' were unexpected)
columns.txt:./source-gitlab-5342-2023-03-26T03:22:30.3501841Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:5343:2023-03-26T03:22:30.3502131Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-5388-2023-03-26T03:22:30.3513474Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:5389:2023-03-26T03:22:30.3513851Z Additional properties are not allowed ('severity', 'epic_iid', 'epic', 'iteration' were unexpected)
columns.txt:./source-gitlab-5487-2023-03-26T03:22:30.3536417Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:5488:2023-03-26T03:22:30.3536789Z Additional properties are not allowed ('erased_at', 'failure_reason', 'project' were unexpected)
columns.txt:./source-gitlab-5551-2023-03-26T03:22:30.3551130Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:5552:2023-03-26T03:22:30.3551444Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-5584-2023-03-26T03:22:30.3558556Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:5585:2023-03-26T03:22:30.3558873Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-5617-2023-03-26T03:22:30.3565724Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:5618:2023-03-26T03:22:30.3566268Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-5747-2023-03-26T03:22:30.3596293Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:5748:2023-03-26T03:22:30.3596715Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-5926-2023-03-26T03:22:30.3646109Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:5927:2023-03-26T03:22:30.3646411Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-5956-2023-03-26T03:22:30.3652641Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:5957:2023-03-26T03:22:30.3652944Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-6521-2023-03-26T03:31:37.1469607Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:6522:2023-03-26T03:31:37.1470579Z Additional properties are not allowed ('wiki_access_level', 'membership_lock', 'prevent_sharing_groups_outside_hierarchy', 'ip_restriction_ranges', 'marked_for_deletion_on' were unexpected)
columns.txt:./source-gitlab-6621-2023-03-26T03:31:37.1521702Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:6622:2023-03-26T03:31:37.1524025Z Additional properties are not allowed ('import_type', 'marked_for_deletion_at', 'allow_pipeline_trigger_approve_deployment', 'keep_latest_artifact', 'feature_flags_access_level', 'approvals_before_merge', 'squash_option', 'security_and_compliance_access_level', 'monitor_access_level', 'runner_token_expiration_interval', 'squash_commit_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'container_registry_access_level', 'ci_separated_caches', 'enforce_auth_checks_on_uploads', 'merge_commit_template', 'requirements_access_level', 'issues_template', 'merge_requests_template', 'ci_job_token_scope_enabled', 'marked_for_deletion_on', 'import_url', 'ci_opt_in_jwt', 'releases_access_level', 'mirror', 'environments_access_level', 'merge_pipelines_enabled', 'issue_branch_template', 'merge_trains_enabled', 'group_runners_enabled' were unexpected)
columns.txt:./source-gitlab-6949-2023-03-26T03:31:37.1760553Z The epics stream has the following schema errors:
columns.txt:./source-gitlab:6950:2023-03-26T03:31:37.1761886Z Additional properties are not allowed ('start_date_from_milestones', 'parent_iid', 'text_color', 'color', 'due_date_from_milestones', 'web_edit_url', '_links' were unexpected)
columns.txt:./source-gitlab-7030-2023-03-26T03:31:37.1801025Z The epic_issues stream has the following schema errors:
columns.txt:./source-gitlab:7031:2023-03-26T03:31:37.1802041Z Additional properties are not allowed ('relative_position', 'type', 'severity', 'service_desk_reply_to', 'has_tasks', 'merge_requests_count', 'iteration', 'blocking_issues_count', 'issue_type', 'epic', 'task_status', 'closed_by', 'task_completion_status', 'moved_to_id', 'epic_iid', 'references' were unexpected)
columns.txt:./source-gitlab-7126-2023-03-26T03:31:37.1852517Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:7127:2023-03-26T03:31:37.1853447Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-7172-2023-03-26T03:31:37.1889728Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:7173:2023-03-26T03:31:37.1890357Z Additional properties are not allowed ('epic', 'epic_iid', 'iteration', 'severity' were unexpected)
columns.txt:./source-gitlab-7277-2023-03-26T03:31:37.1974851Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:7278:2023-03-26T03:31:37.1975973Z Additional properties are not allowed ('erased_at', 'failure_reason', 'project' were unexpected)
columns.txt:./source-gitlab-7341-2023-03-26T03:31:37.2019792Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:7342:2023-03-26T03:31:37.2020825Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-7374-2023-03-26T03:31:37.2045181Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:7375:2023-03-26T03:31:37.2046178Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-7407-2023-03-26T03:31:37.2070382Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:7408:2023-03-26T03:31:37.2071583Z Additional properties are not allowed ('draft', 'merge_user', 'squash_on_merge', 'detailed_merge_status' were unexpected)
columns.txt:./source-gitlab-7537-2023-03-26T03:31:37.2176019Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:7538:2023-03-26T03:31:37.2177280Z Additional properties are not allowed ('draft', 'merge_user', 'squash_on_merge', 'detailed_merge_status' were unexpected)
columns.txt:./source-gitlab-7716-2023-03-26T03:31:37.2257974Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:7717:2023-03-26T03:31:37.2258505Z Additional properties are not allowed ('iid', 'source' were unexpected)
columns.txt:./source-gitlab-7746-2023-03-26T03:31:37.2269797Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:7747:2023-03-26T03:31:37.2270318Z Additional properties are not allowed ('iid', 'source' were unexpected)
columns.txt:./source-gitlab-7908-2023-03-26T03:31:37.2449617Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:7909:2023-03-26T03:31:37.2449982Z Additional properties are not allowed ('wiki_access_level', 'membership_lock' were unexpected)
columns.txt:./source-gitlab-8001-2023-03-26T03:31:37.2474012Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:8002:2023-03-26T03:31:37.2475465Z Additional properties are not allowed ('import_type', 'keep_latest_artifact', 'feature_flags_access_level', 'squash_option', 'security_and_compliance_access_level', 'monitor_access_level', 'runner_token_expiration_interval', 'squash_commit_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'container_registry_access_level', 'ci_separated_caches', 'enforce_auth_checks_on_uploads', 'merge_commit_template', 'requirements_access_level', 'ci_job_token_scope_enabled', 'import_url', 'ci_opt_in_jwt', 'releases_access_level', 'environments_access_level', 'issue_branch_template', 'group_runners_enabled' were unexpected)
columns.txt:./source-gitlab-8321-2023-03-26T03:31:37.2572006Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:8322:2023-03-26T03:31:37.2572291Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-8367-2023-03-26T03:31:37.2583806Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:8368:2023-03-26T03:31:37.2584100Z Additional properties are not allowed ('severity' was unexpected)
columns.txt:./source-gitlab-8462-2023-03-26T03:31:37.2606228Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:8463:2023-03-26T03:31:37.2606608Z Additional properties are not allowed ('erased_at', 'failure_reason', 'project' were unexpected)
columns.txt:./source-gitlab-8526-2023-03-26T03:31:37.2620849Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:8527:2023-03-26T03:31:37.2621198Z Additional properties are not allowed ('created_by', 'membership_state' were unexpected)
columns.txt:./source-gitlab-8565-2023-03-26T03:31:37.2629792Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:8566:2023-03-26T03:31:37.2630106Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-8598-2023-03-26T03:31:37.2637267Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:8599:2023-03-26T03:31:37.2637700Z Additional properties are not allowed ('draft', 'merge_user', 'squash_on_merge', 'detailed_merge_status' were unexpected)
columns.txt:./source-gitlab-8716-2023-03-26T03:31:37.2665015Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:8717:2023-03-26T03:31:37.2665445Z Additional properties are not allowed ('draft', 'merge_user', 'squash_on_merge', 'detailed_merge_status' were unexpected)
columns.txt:./source-gitlab-8893-2023-03-26T03:31:37.2708338Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:8894:2023-03-26T03:31:37.2708661Z Additional properties are not allowed ('iid', 'source' were unexpected)
columns.txt:./source-gitlab-8923-2023-03-26T03:31:37.2715489Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:8924:2023-03-26T03:31:37.2715799Z Additional properties are not allowed ('iid', 'source' were unexpected)
columns.txt:./source-gitlab-9081-2023-03-26T03:31:37.2929548Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:9082:2023-03-26T03:31:37.2930111Z Additional properties are not allowed ('wiki_access_level', 'membership_lock', 'prevent_sharing_groups_outside_hierarchy', 'ip_restriction_ranges', 'marked_for_deletion_on' were unexpected)
columns.txt:./source-gitlab-9181-2023-03-26T03:31:37.2953661Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:9182:2023-03-26T03:31:37.2955122Z Additional properties are not allowed ('import_type', 'keep_latest_artifact', 'feature_flags_access_level', 'squash_option', 'security_and_compliance_access_level', 'monitor_access_level', 'runner_token_expiration_interval', 'squash_commit_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'container_registry_access_level', 'ci_separated_caches', 'enforce_auth_checks_on_uploads', 'merge_commit_template', 'requirements_access_level', 'ci_job_token_scope_enabled', 'import_url', 'ci_opt_in_jwt', 'releases_access_level', 'environments_access_level', 'issue_branch_template', 'group_runners_enabled' were unexpected)
columns.txt:./source-gitlab-9501-2023-03-26T03:31:37.3049187Z The epics stream has the following schema errors:
columns.txt:./source-gitlab:9502:2023-03-26T03:31:37.3049712Z Additional properties are not allowed ('start_date_from_milestones', 'parent_iid', 'text_color', 'color', 'due_date_from_milestones', 'web_edit_url', '_links' were unexpected)
columns.txt:./source-gitlab-9582-2023-03-26T03:31:37.3068186Z The epic_issues stream has the following schema errors:
columns.txt:./source-gitlab:9583:2023-03-26T03:31:37.3068966Z Additional properties are not allowed ('relative_position', 'type', 'severity', 'service_desk_reply_to', 'has_tasks', 'merge_requests_count', 'iteration', 'blocking_issues_count', 'issue_type', 'epic', 'task_status', 'closed_by', 'task_completion_status', 'moved_to_id', 'epic_iid', 'references' were unexpected)
columns.txt:./source-gitlab-9678-2023-03-26T03:31:37.3090346Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:9679:2023-03-26T03:31:37.3090633Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-9724-2023-03-26T03:31:37.3102249Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:9725:2023-03-26T03:31:37.3102550Z Additional properties are not allowed ('severity' was unexpected)
columns.txt:./source-gitlab-9819-2023-03-26T03:31:37.3124616Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:9820:2023-03-26T03:31:37.3124998Z Additional properties are not allowed ('erased_at', 'failure_reason', 'project' were unexpected)
columns.txt:./source-gitlab-9883-2023-03-26T03:31:37.3139180Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:9884:2023-03-26T03:31:37.3139523Z Additional properties are not allowed ('created_by', 'membership_state' were unexpected)
columns.txt:./source-gitlab-9922-2023-03-26T03:31:37.3148359Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:9923:2023-03-26T03:31:37.3148671Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-9955-2023-03-26T03:31:37.3155477Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:9956:2023-03-26T03:31:37.3155908Z Additional properties are not allowed ('draft', 'merge_user', 'squash_on_merge', 'detailed_merge_status' were unexpected)
columns.txt:./source-gitlab-10073-2023-03-26T03:31:37.3183614Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:10074:2023-03-26T03:31:37.3184044Z Additional properties are not allowed ('draft', 'merge_user', 'squash_on_merge', 'detailed_merge_status' were unexpected)
columns.txt:./source-gitlab-10250-2023-03-26T03:31:37.3226466Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:10251:2023-03-26T03:31:37.3226773Z Additional properties are not allowed ('iid', 'source' were unexpected)
columns.txt:./source-gitlab-10280-2023-03-26T03:31:37.3233236Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:10281:2023-03-26T03:31:37.3233550Z Additional properties are not allowed ('iid', 'source' were unexpected)
columns.txt:./source-gitlab-10844-2023-03-26T03:40:39.5791126Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:10845:2023-03-26T03:40:39.5792606Z Additional properties are not allowed ('marked_for_deletion_on', 'membership_lock', 'prevent_sharing_groups_outside_hierarchy', 'ip_restriction_ranges', 'wiki_access_level' were unexpected)
columns.txt:./source-gitlab-10944-2023-03-26T03:40:39.5872672Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:10945:2023-03-26T03:40:39.5876386Z Additional properties are not allowed ('container_registry_access_level', 'mirror', 'merge_requests_template', 'merge_commit_template', 'issue_branch_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'runner_token_expiration_interval', 'ci_opt_in_jwt', 'allow_pipeline_trigger_approve_deployment', 'marked_for_deletion_on', 'enforce_auth_checks_on_uploads', 'ci_separated_caches', 'issues_template', 'merge_trains_enabled', 'marked_for_deletion_at', 'import_type', 'squash_commit_template', 'merge_pipelines_enabled', 'monitor_access_level', 'releases_access_level', 'keep_latest_artifact', 'environments_access_level', 'approvals_before_merge', 'requirements_access_level', 'import_url', 'group_runners_enabled', 'ci_job_token_scope_enabled', 'security_and_compliance_access_level', 'feature_flags_access_level', 'squash_option' were unexpected)
columns.txt:./source-gitlab-11274-2023-03-26T03:40:39.6220599Z The epics stream has the following schema errors:
columns.txt:./source-gitlab:11275:2023-03-26T03:40:39.6221357Z Additional properties are not allowed ('start_date_from_milestones', 'web_edit_url', 'text_color', 'due_date_from_milestones', '_links', 'color', 'parent_iid' were unexpected)
columns.txt:./source-gitlab-11355-2023-03-26T03:40:39.6257589Z The epic_issues stream has the following schema errors:
columns.txt:./source-gitlab:11356:2023-03-26T03:40:39.6258627Z Additional properties are not allowed ('closed_by', 'task_completion_status', 'issue_type', 'severity', 'service_desk_reply_to', 'has_tasks', 'references', 'blocking_issues_count', 'type', 'merge_requests_count', 'relative_position', 'epic_iid', 'moved_to_id', 'task_status', 'epic', 'iteration' were unexpected)
columns.txt:./source-gitlab-11451-2023-03-26T03:40:39.6305612Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:11452:2023-03-26T03:40:39.6306158Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-11497-2023-03-26T03:40:39.6332737Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:11498:2023-03-26T03:40:39.6333763Z Additional properties are not allowed ('severity', 'iteration', 'epic_iid', 'epic' were unexpected)
columns.txt:./source-gitlab-11596-2023-03-26T03:40:39.6395668Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:11597:2023-03-26T03:40:39.6396270Z Additional properties are not allowed ('erased_at', 'project', 'failure_reason' were unexpected)
columns.txt:./source-gitlab-11660-2023-03-26T03:40:39.6431088Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:11661:2023-03-26T03:40:39.6432012Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-11693-2023-03-26T03:40:39.6463581Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:11694:2023-03-26T03:40:39.6464153Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-11726-2023-03-26T03:40:39.6478292Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:11727:2023-03-26T03:40:39.6478993Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-11844-2023-03-26T03:40:39.6527621Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:11845:2023-03-26T03:40:39.6528107Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-12021-2023-03-26T03:40:39.6570860Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:12022:2023-03-26T03:40:39.6571240Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-12051-2023-03-26T03:40:39.6577431Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:12052:2023-03-26T03:40:39.6577739Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-12213-2023-03-26T03:40:39.6730554Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:12214:2023-03-26T03:40:39.6730992Z Additional properties are not allowed ('membership_lock', 'wiki_access_level' were unexpected)
columns.txt:./source-gitlab-12306-2023-03-26T03:40:39.6753492Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:12307:2023-03-26T03:40:39.6754948Z Additional properties are not allowed ('container_registry_access_level', 'merge_commit_template', 'issue_branch_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'runner_token_expiration_interval', 'ci_opt_in_jwt', 'enforce_auth_checks_on_uploads', 'ci_separated_caches', 'import_type', 'squash_commit_template', 'monitor_access_level', 'releases_access_level', 'keep_latest_artifact', 'environments_access_level', 'requirements_access_level', 'import_url', 'group_runners_enabled', 'ci_job_token_scope_enabled', 'security_and_compliance_access_level', 'feature_flags_access_level', 'squash_option' were unexpected)
columns.txt:./source-gitlab-12626-2023-03-26T03:40:39.6838663Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:12627:2023-03-26T03:40:39.6838939Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-12672-2023-03-26T03:40:39.6862808Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:12673:2023-03-26T03:40:39.6863106Z Additional properties are not allowed ('severity' was unexpected)
columns.txt:./source-gitlab-12767-2023-03-26T03:40:39.6885362Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:12768:2023-03-26T03:40:39.6885733Z Additional properties are not allowed ('erased_at', 'project', 'failure_reason' were unexpected)
columns.txt:./source-gitlab-12831-2023-03-26T03:40:39.6899809Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:12832:2023-03-26T03:40:39.6900163Z Additional properties are not allowed ('membership_state', 'created_by' were unexpected)
columns.txt:./source-gitlab-12870-2023-03-26T03:40:39.6909041Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:12871:2023-03-26T03:40:39.6909354Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-12903-2023-03-26T03:40:39.6916150Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:12904:2023-03-26T03:40:39.6916575Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-13021-2023-03-26T03:40:39.6944618Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:13022:2023-03-26T03:40:39.6945045Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-13198-2023-03-26T03:40:39.6987569Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:13199:2023-03-26T03:40:39.6987877Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-13228-2023-03-26T03:40:39.6994874Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:13229:2023-03-26T03:40:39.6995186Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-13386-2023-03-26T03:40:39.7194213Z The groups stream has the following schema errors:
columns.txt:./source-gitlab:13387:2023-03-26T03:40:39.7194951Z Additional properties are not allowed ('marked_for_deletion_on', 'membership_lock', 'prevent_sharing_groups_outside_hierarchy', 'ip_restriction_ranges', 'wiki_access_level' were unexpected)
columns.txt:./source-gitlab-13486-2023-03-26T03:40:39.7228907Z The projects stream has the following schema errors:
columns.txt:./source-gitlab:13487:2023-03-26T03:40:39.7230467Z Additional properties are not allowed ('container_registry_access_level', 'merge_commit_template', 'issue_branch_template', 'infrastructure_access_level', 'ci_allow_fork_pipelines_to_run_in_parent_project', 'runner_token_expiration_interval', 'ci_opt_in_jwt', 'enforce_auth_checks_on_uploads', 'ci_separated_caches', 'import_type', 'squash_commit_template', 'monitor_access_level', 'releases_access_level', 'keep_latest_artifact', 'environments_access_level', 'requirements_access_level', 'import_url', 'group_runners_enabled', 'ci_job_token_scope_enabled', 'security_and_compliance_access_level', 'feature_flags_access_level', 'squash_option' were unexpected)
columns.txt:./source-gitlab-13806-2023-03-26T03:40:39.7337384Z The epics stream has the following schema errors:
columns.txt:./source-gitlab:13807:2023-03-26T03:40:39.7337908Z Additional properties are not allowed ('start_date_from_milestones', 'web_edit_url', 'text_color', 'due_date_from_milestones', '_links', 'color', 'parent_iid' were unexpected)
columns.txt:./source-gitlab-13887-2023-03-26T03:40:39.7356262Z The epic_issues stream has the following schema errors:
columns.txt:./source-gitlab:13888:2023-03-26T03:40:39.7357042Z Additional properties are not allowed ('closed_by', 'task_completion_status', 'issue_type', 'severity', 'service_desk_reply_to', 'has_tasks', 'references', 'blocking_issues_count', 'type', 'merge_requests_count', 'relative_position', 'epic_iid', 'moved_to_id', 'task_status', 'epic', 'iteration' were unexpected)
columns.txt:./source-gitlab-13983-2023-03-26T03:40:39.7378288Z The group_issue_boards stream has the following schema errors:
columns.txt:./source-gitlab:13984:2023-03-26T03:40:39.7378573Z Additional properties are not allowed ('group' was unexpected)
columns.txt:./source-gitlab-14029-2023-03-26T03:40:39.7390083Z The issues stream has the following schema errors:
columns.txt:./source-gitlab:14030:2023-03-26T03:40:39.7390376Z Additional properties are not allowed ('severity' was unexpected)
columns.txt:./source-gitlab-14124-2023-03-26T03:40:39.7412461Z The jobs stream has the following schema errors:
columns.txt:./source-gitlab:14125:2023-03-26T03:40:39.7412831Z Additional properties are not allowed ('erased_at', 'project', 'failure_reason' were unexpected)
columns.txt:./source-gitlab-14188-2023-03-26T03:40:39.7427141Z The project_members stream has the following schema errors:
columns.txt:./source-gitlab:14189:2023-03-26T03:40:39.7427497Z Additional properties are not allowed ('membership_state', 'created_by' were unexpected)
columns.txt:./source-gitlab-14227-2023-03-26T03:40:39.7436092Z The group_members stream has the following schema errors:
columns.txt:./source-gitlab:14228:2023-03-26T03:40:39.7436411Z Additional properties are not allowed ('membership_state' was unexpected)
columns.txt:./source-gitlab-14260-2023-03-26T03:40:39.7443541Z The merge_requests stream has the following schema errors:
columns.txt:./source-gitlab:14261:2023-03-26T03:40:39.7443960Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-14378-2023-03-26T03:40:39.7475594Z The merge_request_commits stream has the following schema errors:
columns.txt:./source-gitlab:14379:2023-03-26T03:40:39.7476268Z Additional properties are not allowed ('draft', 'detailed_merge_status', 'merge_user', 'squash_on_merge' were unexpected)
columns.txt:./source-gitlab-14555-2023-03-26T03:40:39.7546127Z The pipelines stream has the following schema errors:
columns.txt:./source-gitlab:14556:2023-03-26T03:40:39.7546446Z Additional properties are not allowed ('source', 'iid' were unexpected)
columns.txt:./source-gitlab-14585-2023-03-26T03:40:39.7552940Z The pipelines_extended stream has the following schema errors:
columns.txt:./source-gitlab:14586:2023-03-26T03:40:39.7553279Z Additional properties are not allowed ('source', 'iid' were unexpected)

  1. Add the missing properties indicated by the Additional properties are not allowed ('<column>', 'column' were unexpected) logs to the connector's spec.
  2. Remove fail_on_extra_columns: false from the acceptance-test-config.yml file.
  3. Commit changes to spec and acceptance-test-config.yml and open a PR.
  4. Run tests on the connector, either automatically via CI or manually via the /test command
  5. Profit!

Definition of done: Gitlab passes CAT without declaring fail_on_extra_columns: false. If the
API starts sending over extra columns in the future, we will catch and fix them as part of the #connector-health
movement.

@evantahler
Copy link
Contributor

When this issue is picked up, please also consult our DataDog Dashboard for Record Unexpected Fields for this connector. The API might be returning even more record properties that need to be added to the catalog.

davydov-d added a commit that referenced this issue Jun 8, 2023
* Connector health: source hubspot, gitlab, snapchat-marketing: fix builds

* #24555 source gitlab: fail on extra columns

* source gitlab: update stream schemas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants