Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI does not protect against misconfiguration for Incremental #2837

Closed
cgardens opened this issue Apr 9, 2021 · 1 comment
Closed

UI does not protect against misconfiguration for Incremental #2837

cgardens opened this issue Apr 9, 2021 · 1 comment
Assignees
@cgardens
Labels
priority/high High priority type/bug Something isn't working
Milestone
Core - 2021-04-23

Comments

@cgardens
Copy link
Contributor

cgardens commented Apr 9, 2021 •
edited
Loading

Expected Behavior

  • For conventional incremental, the UI should force the user to set the cursor field.
  • For cdc incremental, the UI should not let the user set a cursor field.

Current Behavior

  • Currently UI allows all incremental (CDC or incremental) to set a cursor field but does not require. This isn't really ever the right behavior. Though we can workaround (and release without fixing)
  • The upside of the current behavior is that both conventional and CDC incremental are workable in the UI. Though it is easy to make mistakes and get confused.

Additional context

we need to...

  1. Make it possible for the UI (or anyone using the API) to distinguish when a source is configured for conventional or CDC incremental. We do not current expose enough info for this.
  2. Have the UI follow the expected behavior mentioned above.

@jrhizor fyi
@cgardens cgardens added type/bug Something isn't working priority/high High priority labels Apr 9, 2021
@cgardens cgardens added this to the Core - 2021-04-16 milestone Apr 9, 2021
@cgardens cgardens self-assigned this Apr 12, 2021
@cgardens cgardens mentioned this issue Apr 13, 2021
Merged
@cgardens
Copy link
Contributor Author

closed by #2878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgardens cgardens

Labels
priority/high High priority type/bug Something isn't working
Projects
None yet
Milestone
Core - 2021-04-23
Development

No branches or pull requests
1 participant
@cgardens