Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set source defined cursor field for cdc #2878

Merged
merged 3 commits into from
Apr 21, 2021
Merged

set source defined cursor field for cdc #2878

merged 3 commits into from
Apr 21, 2021

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented Apr 13, 2021 •
edited
Loading

relates to #2837

What

  • Users should not be able to set a cursor field on cdc sources. This is part 1 of 2. Part 2 is for the UI to not allow users to do this if source defined is true.

@auto-assign auto-assign bot requested review from jrhizor and michel-tricot April 13, 2021 22:02
michel-tricot
michel-tricot reviewed Apr 13, 2021
View reviewed changes
Copy link
Contributor

@michel-tricot michel-tricot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgardens cgardens force-pushed the cgardens/cdc_uses_source_defined branch from 75ca914 to 4840754 Compare April 19, 2021 16:57
@cgardens
Copy link
Contributor Author

cgardens commented Apr 19, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-posgres

🕑 connectors/source-posgres https://github.com/airbytehq/airbyte/actions/runs/764337144
❌ connectors/source-posgres https://github.com/airbytehq/airbyte/actions/runs/764337144

@cgardens
Copy link
Contributor Author

cgardens commented Apr 19, 2021 •
edited by github-actions bot
Loading

/publish connector=source-posgres

❌ source-posgres https://github.com/airbytehq/airbyte/actions/runs/764366589

@cgardens
Copy link
Contributor Author

cgardens commented Apr 19, 2021 •
edited by github-actions bot
Loading

/publish connector=source-postgres

❌ source-postgres https://github.com/airbytehq/airbyte/actions/runs/764381686

@cgardens
Copy link
Contributor Author

cgardens commented Apr 19, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/764382865
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/764382865

@cgardens
Copy link
Contributor Author

cgardens commented Apr 19, 2021 •
edited by github-actions bot
Loading

/test connector=source-postgres

🕑 source-postgres https://github.com/airbytehq/airbyte/actions/runs/764388791
❌ source-postgres https://github.com/airbytehq/airbyte/actions/runs/764388791

@cgardens
Copy link
Contributor Author

cgardens commented Apr 19, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/764389042
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/764389042

@cgardens cgardens force-pushed the cgardens/cdc_uses_source_defined branch from d78e857 to 1ae7a4e Compare April 21, 2021 17:33
@cgardens
Copy link
Contributor Author

cgardens commented Apr 21, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/771640688
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/771640688

@cgardens
Copy link
Contributor Author

cgardens commented Apr 21, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/771641654
❌ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/771641654

@cgardens cgardens merged commit e4d227f into master Apr 21, 2021
@cgardens cgardens deleted the cgardens/cdc_uses_source_defined branch April 21, 2021 22:07
@cgardens cgardens mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-tricot michel-tricot michel-tricot left review comments

@sherifnada sherifnada sherifnada approved these changes

@jrhizor jrhizor jrhizor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgardens @jrhizor @michel-tricot @sherifnada