Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery destination: make credentials json optional #3657

Closed
akoshterek opened this issue May 27, 2021 · 2 comments
Closed

BigQuery destination: make credentials json optional #3657

akoshterek opened this issue May 27, 2021 · 2 comments

Comments

@akoshterek
Copy link

akoshterek commented May 27, 2021

Tell us about the problem you're trying to solve

You don't need explicit authentication when a service is running inside Google Compute/Kubernetes engine with a proper service account

Describe the solution you’d like

Make service account json field optional and don't try to authenticate when it's empty.

Are you willing to submit a PR?

Yes

┆Issue is synchronized with this Asana task by Unito

@akoshterek akoshterek added the type/enhancement New feature or request label May 27, 2021
@sherifnada
Copy link
Contributor

sherifnada commented May 27, 2021

@akoshterek I'm trying to think of what the right UX/interface here should be.

Maybe we should have something like a drop down list which asks you the kind of auth method you want. One is "no auth" for your case. Another is "Service Account JSON credentials". This is easier to understand as it makes the user think about it (instead of them forgetting to input JSON credentials for example)

What do you think? Also would you be open to creating a PR to do this? happy to provide guidance on it

@sherifnada sherifnada added the area/connectors Connector related issues label May 27, 2021
@akoshterek
Copy link
Author

@sherifnada "No auth" would be misleading imho. It can use a service account attached to the VM or even your personal account when you're logged in GCP on your local machine.

So possibly
"Default auth" and "Service Account JSON credentials"?

With 1st option selected json field should be disabled or disappear, not sure what is possible with spec.json

Yes, I can handle it

daleksic pushed a commit to daleksic/airbyte that referenced this issue Jun 4, 2021
marcosmarxm pushed a commit that referenced this issue Jun 17, 2021
* Make credentials optional for BigQuery connector

* Bump destination-bigquery version 0.3.5 -> 0.3.6

Co-authored-by: Sabolc Franjo <sabolc.franjo@ev-box.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants