🎉 Make credentials optional in BigQuery connector (issue #3657) #3947
+27
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Issue #3657
How
Solved by making the field optional and using default application credentials in code when the field is empty.
Pre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
Issue acceptance criteria met
Unit & integration tests added as appropriate (and are passing)
/test
command documented here is passing.Code reviews completed
Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
Documentation updated
docs/integrations/
directory.Build is successful
Connector version bumped like described here
New Connector version released on Dockerhub by running the
/publish
command described hereNo major blockers
PR merged into master branch
Follow up tickets have been created
Associated tickets have been closed & stakeholders notified