Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regex patterns for all fields in integration configurations #454

Closed
cgardens opened this issue Sep 24, 2020 · 1 comment
Closed

Add regex patterns for all fields in integration configurations #454

cgardens opened this issue Sep 24, 2020 · 1 comment
Labels
area/connectors Connector related issues type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

cgardens commented Sep 24, 2020 •
edited by sync-by-unito bot
Loading

Tell us about the problem you're trying to solve

  • We should give as much help as possible to the user to prevent them misconfiguring an integration.

Describe the solution you’d like

  • If we add the pattern field for each field in their configuration this will block the user from putting in invalid data for a configuration. In doing this, we need to make sure we put enough information in the description field, so that it is clear to the user what their configuration should look like so they are not getting inexplicable failures.

┆Issue is synchronized with this Asana task by Unito
@cgardens cgardens added type/enhancement New feature or request area/connectors Connector related issues labels Sep 24, 2020
@cgardens
Copy link
Contributor Author

I think we have pretty reasonably picked this up as a best practice. Adding this suggestion to the best practices and closing this issue.

@cgardens cgardens mentioned this issue May 27, 2021
Closed
davydov-d added a commit that referenced this issue Sep 21, 2022
@davydov-d
#454 oncall source salesforce: handle japanese characters
3c0dc92
davydov-d added a commit that referenced this issue Sep 22, 2022
@davydov-d
#454 source salesforce: adjust public interface to CDK, do not take i…
5d75abd 
…nto account state when choosing the API type
davydov-d added a commit that referenced this issue Sep 22, 2022
@davydov-d @octavia-squidington-iii
Source salesforce: handle japanese characters (#17001)
596a436 
* #454 oncall source salesforce: handle japanese characters

* source salesforce: upd changelog

* source salesforce: flake fix

* #454 source salesforce: adjust public interface to CDK, do not take into account state when choosing the API type

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
robbinhan pushed a commit to robbinhan/airbyte that referenced this issue Sep 29, 2022
@davydov-d @octavia-squidington-iii @robbinhan
Source salesforce: handle japanese characters (airbytehq#17001)
d0eb791 
* airbytehq#454 oncall source salesforce: handle japanese characters

* source salesforce: upd changelog

* source salesforce: flake fix

* airbytehq#454 source salesforce: adjust public interface to CDK, do not take into account state when choosing the API type

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this issue Oct 31, 2022
@davydov-d @octavia-squidington-iii @jhammarstedt
Source salesforce: handle japanese characters (airbytehq#17001)
f04c90c 
* airbytehq#454 oncall source salesforce: handle japanese characters

* source salesforce: upd changelog

* source salesforce: flake fix

* airbytehq#454 source salesforce: adjust public interface to CDK, do not take into account state when choosing the API type

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connectors Connector related issues type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgardens