-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Google Direcotry: support oauth #6265
Comments
sherifnada
changed the title
Source Google: support oauth
Source Google Direcotry: support oauth
Sep 20, 2021
vitaliizazmic
added a commit
that referenced
this issue
Oct 27, 2021
vitaliizazmic
added a commit
that referenced
this issue
Oct 27, 2021
10 tasks
vitaliizazmic
added a commit
that referenced
this issue
Oct 28, 2021
vitaliizazmic
added a commit
that referenced
this issue
Oct 29, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 2, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 3, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 5, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 5, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 5, 2021
* Source Google Directory #6265 - add oauth support * Source Google Directory #6265 - update credentials * Source Google Directory #6265 - fixing according to PR * Source Google directory #6265 - update docs * Source Google directory #5190 - update doc * Source Google Directory #6265 - resolve merge conflict * Source Google Directory #6265 - SAT for oauth * Source Google Directory #6265 - bump version and update changelog * Source Google Directory #6265 - bump version and update changelog (update publish)
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this issue
Jan 4, 2022
* Source Google Directory airbytehq#6265 - add oauth support * Source Google Directory airbytehq#6265 - update credentials * Source Google Directory airbytehq#6265 - fixing according to PR * Source Google directory airbytehq#6265 - update docs * Source Google directory airbytehq#5190 - update doc * Source Google Directory airbytehq#6265 - resolve merge conflict * Source Google Directory airbytehq#6265 - SAT for oauth * Source Google Directory airbytehq#6265 - bump version and update changelog * Source Google Directory airbytehq#6265 - bump version and update changelog (update publish)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tell us about the problem you're trying to solve
With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.
If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:
If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":
{ authentication: { type: object oneOf: [ // api key, // oauth ] } }
If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.
See the connector spec reference in the docs for reference on how a oneof can be implemented.
This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: