Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Square: support oauth #6282

Closed
1 task done
sherifnada opened this issue Sep 19, 2021 · 1 comment · Fixed by #6842
Closed
1 task done

Source Square: support oauth #6282

sherifnada opened this issue Sep 19, 2021 · 1 comment · Fixed by #6842

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Sep 19, 2021

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:

If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret in a backwards compatible manner
  2. Oauth properties are annotated properly. See this PR for an example
@sherifnada sherifnada added area/oauth area/connectors Connector related issues labels Sep 19, 2021
@igrankova igrankova assigned igrankova and unassigned igrankova Sep 27, 2021
@cheyura cheyura self-assigned this Sep 30, 2021
@midavadim midavadim assigned midavadim and unassigned cheyura Sep 30, 2021
@cheyura
Copy link

cheyura commented Oct 3, 2021

@midavadim Oauth clients are here https://developer.squareup.com/apps/sq0idp-7KVC6qHcSDMXsm40SAA9TA/oauth, Name of app "Airbyte_test_app". For both prod and sandbox oauth flow is tested. Please check if data in sandbox https://squareupsandbox.com/dashboard/ is enough for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants