🎉 square: added oauth support #6842

midavadim · 2021-10-06T16:24:57Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

This change is

CLAassistant · 2021-10-06T16:25:11Z

All committers have signed the CLA.

airbyte-integrations/connectors/source-square/integration_tests/configured_catalog.json

airbyte-integrations/connectors/source-square/source_square/source.py

midavadim · 2021-10-06T16:43:08Z

/test connector=connectors/square

🕑 connectors/square https://github.com/airbytehq/airbyte/actions/runs/1312818892
❌ connectors/square https://github.com/airbytehq/airbyte/actions/runs/1312818892
🐛

midavadim · 2021-10-06T20:45:14Z

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1313596201
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1313596201
🐛 https://gradle.com/s/q3vhv2x37fdcg

midavadim · 2021-10-07T19:33:08Z

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1317639508
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1317639508
🐛

midavadim · 2021-10-07T19:54:27Z

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1317703454
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1317703454
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     111     11    90%
	 ------------------------------------------------------------------------
	 TOTAL                                                  856    416    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_square/__init__.py       2      0   100%
	 source_square/source.py       228     97    57%
	 source_square/utils.py         15      0   100%
	 -----------------------------------------------
	 TOTAL                         245     97    60%

airbyte-integrations/connectors/source-square/source_square/source.py

antixar

could you rename the secret value?
SOURCE_SQUARE_CREDS_OAUTH => SOURCE_SQUARE_OAUTH_CREDS

bazarnov

Please check the TypeHints in Oauth2AuthenticatorSquare(Oauth2Authenticator) and spec.json for OAuth Flow specifications

airbyte-integrations/connectors/source-square/acceptance-test-config.yml

airbyte-integrations/connectors/source-square/integration_tests/configured_catalog.json

airbyte-integrations/connectors/source-square/integration_tests/invalid_config.json

airbyte-integrations/connectors/source-square/source_square/spec.json

midavadim · 2022-01-14T17:15:16Z

/test connector=connectors/source-square

midavadim · 2022-01-17T09:43:30Z

/test connector=connectors/source-square

…uare-oauth-support

midavadim · 2022-01-17T19:30:59Z

/test connector=connectors/source-square

This reverts commit ce3d061.

midavadim · 2022-01-17T19:53:54Z

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1709659517
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1709659517
🐛 https://scans.gradle.com/s/u2txu7m35b5hi
Python short test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestConnection::test_check[inputs1] - FileNotFoundError: ...
ERROR test_core.py::TestDiscovery::test_discover[inputs1] - FileNotFoundError...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs1]
ERROR test_core.py::TestBasicRead::test_read[inputs1] - FileNotFoundError: [E...
======================== 16 passed, 5 errors in 33.05s =========================

midavadim · 2022-01-17T20:28:33Z

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1709768838
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1709768838
🐛 https://scans.gradle.com/s/o4n3pd75qgvai
Python short test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestConnection::test_check[inputs1] - FileNotFoundError: ...
ERROR test_core.py::TestDiscovery::test_discover[inputs1] - FileNotFoundError...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs1]
ERROR test_core.py::TestBasicRead::test_read[inputs1] - FileNotFoundError: [E...
======================== 16 passed, 5 errors in 32.87s =========================

midavadim · 2022-01-17T20:43:35Z

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1709813658
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1709813658
🐛 https://scans.gradle.com/s/qj72dim7nstze
Python short test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestConnection::test_check[inputs1] - FileNotFoundError: ...
ERROR test_core.py::TestDiscovery::test_discover[inputs1] - FileNotFoundError...
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs1]
ERROR test_core.py::TestBasicRead::test_read[inputs1] - FileNotFoundError: [E...
======================== 16 passed, 5 errors in 33.15s =========================

midavadim · 2022-01-17T20:58:52Z

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1709855680
❌ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1709855680
🐛 https://scans.gradle.com/s/bft3nloj7agz4

midavadim · 2022-01-18T06:20:20Z

/test connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1711324262
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1711324262
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_square/__init__.py       2      0   100%
	 source_square/source.py       234    100    57%
	 source_square/utils.py         15      0   100%
	 -----------------------------------------------
	 TOTAL                         251    100    60%

midavadim · 2022-01-18T06:49:52Z

/publish connector=connectors/source-square

🕑 connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1711405457
✅ connectors/source-square https://github.com/airbytehq/airbyte/actions/runs/1711405457

midavadim added 2 commits October 4, 2021 19:20

fixed test which check incorrect cred config

2754a2a

Added oauth2 authentication

4b29f13

midavadim temporarily deployed to more-secrets October 6, 2021 16:25 Inactive

midavadim requested a review from antixar October 6, 2021 16:25

github-actions bot added the area/connectors Connector related issues label Oct 6, 2021

Added oauth creds

633b967

midavadim temporarily deployed to more-secrets October 6, 2021 16:37 Inactive

midavadim linked an issue Oct 6, 2021 that may be closed by this pull request

Source Square: support oauth #6282

Closed

1 task

midavadim commented Oct 6, 2021

View reviewed changes

airbyte-integrations/connectors/source-square/integration_tests/configured_catalog.json Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-square/source_square/source.py Show resolved Hide resolved

jrhizor temporarily deployed to more-secrets October 6, 2021 16:45 Inactive

jrhizor temporarily deployed to more-secrets October 6, 2021 20:47 Inactive

midavadim mentioned this pull request Oct 7, 2021

🐛 CDK: HttpStream authenticator property should also returns AuthBase objects #6844

Closed

38 tasks

antixar requested a review from bazarnov October 7, 2021 15:59

jrhizor temporarily deployed to more-secrets October 7, 2021 19:35 Inactive

fixed formatting

9e11b0d

midavadim temporarily deployed to more-secrets October 7, 2021 19:43 Inactive

jrhizor temporarily deployed to more-secrets October 7, 2021 19:56 Inactive

bazarnov requested changes Oct 8, 2021

View reviewed changes

antixar reviewed Oct 8, 2021

View reviewed changes

midavadim requested review from antixar and bazarnov October 15, 2021 11:46

bazarnov requested changes Oct 15, 2021

View reviewed changes

added oauth2 spec section, added missing type hints

2993e77

midavadim temporarily deployed to more-secrets October 15, 2021 12:57 Inactive

midavadim requested a review from bazarnov October 15, 2021 13:03

ChristopheDuong approved these changes Jan 13, 2022

View reviewed changes

octavia-squidington-iii temporarily deployed to more-secrets January 14, 2022 17:17 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 09:45 Inactive

midavadim added 2 commits January 17, 2022 21:24

updated source version

ce3d061

Merge remote-tracking branch 'origin/master' into midavadim/source-sq…

d6f3447

…uare-oauth-support

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 19:33 Inactive

Revert "updated source version"

64e2835

This reverts commit ce3d061.

midavadim temporarily deployed to more-secrets January 17, 2022 19:55 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 19:56 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 20:31 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 20:46 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 17, 2022 21:01 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 06:22 Inactive

updated source version

0f67641

midavadim temporarily deployed to more-secrets January 18, 2022 06:48 Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 18, 2022 06:52 Inactive

added new version for airbyte index

d9f0ca7

midavadim merged commit 6b502d8 into master Jan 18, 2022

midavadim deleted the midavadim/source-square-oauth-support branch January 18, 2022 07:11

midavadim temporarily deployed to more-secrets January 18, 2022 07:12 Inactive

octavia-squidington-iii mentioned this pull request Jan 20, 2022

Bump Airbyte version from 0.35.5-alpha to 0.35.6-alpha #9630

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 square: added oauth support #6842

🎉 square: added oauth support #6842

midavadim commented Oct 6, 2021 •

edited by keu

Loading

CLAassistant commented Oct 6, 2021 •

edited

Loading

midavadim commented Oct 6, 2021 •

edited by github-actions bot

Loading

midavadim commented Oct 6, 2021 •

edited by github-actions bot

Loading

midavadim commented Oct 7, 2021 •

edited by github-actions bot

Loading

midavadim commented Oct 7, 2021 •

edited by github-actions bot

Loading

antixar left a comment

bazarnov left a comment

midavadim commented Jan 14, 2022

midavadim commented Jan 17, 2022

midavadim commented Jan 17, 2022

midavadim commented Jan 17, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 18, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 18, 2022 •

edited by github-actions bot

Loading

🎉 square: added oauth support #6842

🎉 square: added oauth support #6842

Conversation

midavadim commented Oct 6, 2021 • edited by keu Loading

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Oct 6, 2021 • edited Loading

midavadim commented Oct 6, 2021 • edited by github-actions bot Loading

midavadim commented Oct 6, 2021 • edited by github-actions bot Loading

midavadim commented Oct 7, 2021 • edited by github-actions bot Loading

midavadim commented Oct 7, 2021 • edited by github-actions bot Loading

antixar left a comment

Choose a reason for hiding this comment

bazarnov left a comment

Choose a reason for hiding this comment

midavadim commented Jan 14, 2022

midavadim commented Jan 17, 2022

midavadim commented Jan 17, 2022

midavadim commented Jan 17, 2022 • edited by github-actions bot Loading

midavadim commented Jan 17, 2022 • edited by github-actions bot Loading

midavadim commented Jan 17, 2022 • edited by github-actions bot Loading

midavadim commented Jan 17, 2022 • edited by github-actions bot Loading

midavadim commented Jan 18, 2022 • edited by github-actions bot Loading

midavadim commented Jan 18, 2022 • edited by github-actions bot Loading

midavadim commented Oct 6, 2021 •

edited by keu

Loading

CLAassistant commented Oct 6, 2021 •

edited

Loading

midavadim commented Oct 6, 2021 •

edited by github-actions bot

Loading

midavadim commented Oct 6, 2021 •

edited by github-actions bot

Loading

midavadim commented Oct 7, 2021 •

edited by github-actions bot

Loading

midavadim commented Oct 7, 2021 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 17, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 18, 2022 •

edited by github-actions bot

Loading

midavadim commented Jan 18, 2022 •

edited by github-actions bot

Loading