Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth flow: Refer to AuthSpecification config to format outputs with correct oauth response structure #7216

Closed
avida opened this issue Oct 20, 2021 · 0 comments · Fixed by #7917
Labels
area/connectors Connector related issues area/oauth lang/java type/enhancement New feature or request

Comments

@avida
Copy link
Contributor

avida commented Oct 20, 2021

For now we have hardcoded object strucutre for each oAuth backend. E.g. for Asana response should be {"credentials": "refresh_token": ".."}, for trello or facebook its plain object {"key": "value", "key2": "value2"}, for some connectors it should be {"authorize": {"key": "value"}} etc.

We need to come up with generic solution to read response structure from connector's spec and not rely on hardcoded structure.
Output object path should consist of first rootObject value and oauthFlowOutputParameters path (except last one which is field name).

@ChristopheDuong ChristopheDuong added this to the ConnCore, Nov 3 2021 milestone Nov 3, 2021
@ChristopheDuong ChristopheDuong changed the title Use spec to get correct oauth response strucuture for complete_oauth call OAuth flow: Refer to AuthSpecification config to format outputs with correct oauth response structure Nov 4, 2021
@sherifnada sherifnada added the area/connectors Connector related issues label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/oauth lang/java type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants