Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source GitLab: support oauth #7480

Closed
Tracked by #7341 ...
igrankova opened this issue Oct 29, 2021 · 0 comments · Fixed by #7506
Closed
Tracked by #7341 ...

Source GitLab: support oauth #7480

igrankova opened this issue Oct 29, 2021 · 0 comments · Fixed by #7506

Comments

@igrankova
Copy link
Contributor

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:

If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret in a backwards compatible manner
  2. Oauth properties are annotated properly. See this PR for an example
@igrankova igrankova added area/connectors Connector related issues area/oauth labels Oct 29, 2021
@bazarnov bazarnov self-assigned this Oct 29, 2021
@bazarnov bazarnov linked a pull request Oct 31, 2021 that will close this issue
11 tasks
@sherifnada sherifnada moved this to Blocked in GL Roadmap Jan 12, 2022
@igrankova igrankova moved this to Blocked in GL Roadmap Feb 2, 2022
@bazarnov bazarnov removed their assignment Oct 18, 2022
@davydov-d davydov-d self-assigned this Dec 1, 2022
davydov-d added a commit that referenced this issue Dec 4, 2022
davydov-d added a commit that referenced this issue Dec 7, 2022
davydov-d added a commit that referenced this issue Dec 8, 2022
davydov-d added a commit that referenced this issue Dec 9, 2022
davydov-d added a commit that referenced this issue Dec 15, 2022
davydov-d added a commit that referenced this issue Dec 16, 2022
davydov-d added a commit that referenced this issue Jan 18, 2023
* added support of oauth2.0

* added OAuthFlow.java part

* bumped version of the Dockerfile

* corrected SAT

* added unit_test for Oauth java part, added integration-test for java part

* added changelog

* fix java part test

* updated after review

* updated spec.json

* updated after review

* #7480 source gitlab: rm empty files

* #7480 source gitlab: add single use refresh token authenticator

* #7480 source gitlab: upd oauth implementation

* #7480 source gitlab: refactor auth

* #7480 fix oauth: java

* #7480 source gitlab: review fixes

* #7480 source gitlab: upd release stage

* #7480 source gitlab: fix unit tests

* #7480 source gitlab: update expected records

* #7480 source gitlab: upd sats

* #7480 source gitlab: upd expected records

* #7480 source Gitlab: use SingleUseRefreshTokenOauth as is

* #7480 sourcte gitlab: upd expected records

* auto-bump connector version

Co-authored-by: Denys Davydov <davydov.den18@gmail.com>
Co-authored-by: Augustin <augustin@airbyte.io>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

4 participants