-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Salesforce: Support oauth'ing into sandbox environment #7722
Labels
area/connectors
Connector related issues
connectors/source/salesforce
connectors/sources-api
priority/high
High priority
type/enhancement
New feature or request
Milestone
Comments
sherifnada
added
type/enhancement
New feature or request
area/connectors
Connector related issues
labels
Nov 8, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 11, 2021
…option of the Salesforce connector
9 tasks
vitaliizazmic
added a commit
that referenced
this issue
Nov 12, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 16, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 17, 2021
vitaliizazmic
added a commit
that referenced
this issue
Nov 17, 2021
blocked by #7915 |
@vitaliizazmic the UI logic has been merged, this issue should no longer be blocked |
vitaliizazmic
added a commit
that referenced
this issue
Dec 14, 2021
Merged
9 tasks
vitaliizazmic
added a commit
that referenced
this issue
Dec 21, 2021
vitaliizazmic
added a commit
that referenced
this issue
Dec 21, 2021
vitaliizazmic
added a commit
that referenced
this issue
Dec 22, 2021
vitaliizazmic
added a commit
that referenced
this issue
Jan 11, 2022
vitaliizazmic
added a commit
that referenced
this issue
Jan 11, 2022
vitaliizazmic
added a commit
that referenced
this issue
Jan 11, 2022
vitaliizazmic
added a commit
that referenced
this issue
Jan 11, 2022
…ching to advanced_auth (#8797) * Source Salesforce #7722 - change spec to use advanced_auth * Source Salesforce #7722 - update oauth flow * Source Salesforce #7722 - reformat * Source Salesforce #7722 - fixing get environment in oauth flow * Source Salesforce #7722 - improve spec * Source Salesforce #7722 - reformat * Source Salesforce #7722 - bump version and update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
connectors/source/salesforce
connectors/sources-api
priority/high
High priority
type/enhancement
New feature or request
Tell us about the problem you're trying to solve
When oauth'ing a salesforce user into a sandbox environment, we need to send them to
test.salesforce.com
rather thanlogin.salesforce.com
. Our current server implementation of salesforce oauth always assumes they are not trying to use a sandbox environment and redirects them tologin.salesforce.com
.Unfortunately, many enterprise users are not allowed to use production environments for testing new tools. Therefore, they would not be able to adopt Airbyte Cloud without being able to access the sandbox environment.
Ideally, we would wait for #6971 to be implemented and use the functionality offered there to implement this flow. However, since that could take some time, we need to come up with a way to allow new Airbyte Cloud customers to start
Once #6971 is implemented, we need to look at the user's input config and determine which oauth configuration to use.
Describe the solution you’d like
This fix has the following components:
sandbox
option of the Salesforce connector and always assume we are using the production environment (remove it from the spec but not from the code, and allow additional properties = true. if the undocumented option is passed then the connector should use sandbox)source-salesforce-sandbox
(similar to thesource-file-secure
fork of thesource-file
connector) which always assumes we are using the salesforce sandbox environment. By the end we should have two salesforce connectors,source-salesforce
which always assumes NOT sandbox, andsource-salesforce-sandbox
which always assumes sandbox environment. Publish both connectors normally like we do with any connector.Salesforce (Sandbox)
Lastpass credentials. The only difference between this flow and the current salesforce flow is that the current salesforce flow uses thelogin.salesforce.com
endpoint whereas the new flow should usetest.salesforce.com
. That's it. Otherwise, it can use the same credentials.The text was updated successfully, but these errors were encountered: