-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic normalization doesn't extract nested objects using $ref
/$defs
#8241
Comments
@alafanechere do you think this #8330 is also same? |
we don't support $ref / $defs in airbyte json schema, so normalization does not support that either The source should resolve and inline the full json into the catalog |
Well, actually, Airbyte does support See the documentation:
|
Sorry for the misunderstanding! That's the documentation page for the CDK and how to ease implementation of source connectors in airbyte. But once the source connector produces the catalog.json in Airbyte's protocol, there should be no more $ref afterward as the CDK/source connector should have inlined all the $ref into a full JSON schema object. The separated YAML/JSON files (used in the refs) are not transmitted through the protocol (only a full json object called catalog), so normalization would not be able to resolve and inline the different JSON object back together. (that's why I said that it is "not supported") see this issue #7966 and its associated PRs where we are adding "Source Acceptance Tests" (SAT) to make sure all $ref are resolved by the source connector before "materializing" the catalog.json (that is used downstream by normalization) |
Enviroment
Current Behavior
Basic normalization doesn't extract nested objects when they're referenced using
$ref
and defined using$defs
in the same schema. The current workaround is to inline all, usually duplicated, object definitions.Example schema that uses
$ref
/$defs
: 5303b0bExpected Behavior
I expect to deduplicate schemas and have all the benefits of basic normalization nested object extraction.
Logs
Failed nested object extraction:
LOG
Steps to Reproduce
$ref
/$defs
, e.g. 5303b0bAre you willing to submit a PR?
Maybe.
The text was updated successfully, but these errors were encountered: