Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source GitHub - added more meaningful error description for connector check #10211

Merged
merged 6 commits into from
Feb 14, 2022

Conversation

midavadim
Copy link
Contributor

@midavadim midavadim commented Feb 9, 2022

What

Errors in UI during connector check:

wrong repo name:
HTTPError('404 Client Error: Not Found for url: https://api.github.com/repos/airbytehq/airbyte3?per_page=100')"

wrong org name:
HTTPError('404 Client Error: Not Found for url: https://api.github.com/orgs/airbytehqBLA/repos?per_page=100')"

How

Added meaningful description for error during connector check

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 9, 2022
@midavadim midavadim temporarily deployed to more-secrets February 9, 2022 08:56 Inactive
@midavadim midavadim requested a review from bazarnov February 9, 2022 08:58
@midavadim midavadim temporarily deployed to more-secrets February 9, 2022 08:59 Inactive
@midavadim
Copy link
Contributor Author

midavadim commented Feb 9, 2022

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1817070443
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1817070443
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/tests/test_incremental.py        69     38    45%
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                        Stmts   Miss  Cover
-----------------------------------------------
source_github/__init__.py       2      0   100%
source_github/source.py        87     44    49%
source_github/streams.py      373    164    56%
-----------------------------------------------
TOTAL                         462    208    55%

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@e30d834). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head aa896f2 differs from pull request most recent head b1b0bf5. Consider uploading reports for the commit b1b0bf5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10211   +/-   ##
=========================================
  Coverage          ?   55.36%           
=========================================
  Files             ?        3           
  Lines             ?      466           
  Branches          ?        0           
=========================================
  Hits              ?      258           
  Misses            ?      208           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e30d834...b1b0bf5. Read the comment docs.

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 9, 2022 09:02 Inactive
@midavadim midavadim requested a review from antixar February 9, 2022 09:50
@midavadim midavadim requested a review from bazarnov February 10, 2022 11:43
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please publish your changes

…e-github-validate-repo-name

# Conflicts:
#	docs/integrations/sources/github.md
@midavadim midavadim temporarily deployed to more-secrets February 14, 2022 12:42 Inactive
@midavadim midavadim temporarily deployed to more-secrets February 14, 2022 12:42 Inactive
@midavadim midavadim temporarily deployed to more-secrets February 14, 2022 12:48 Inactive
@midavadim midavadim temporarily deployed to more-secrets February 14, 2022 12:48 Inactive
@midavadim
Copy link
Contributor Author

midavadim commented Feb 14, 2022

/publish connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1841105150
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/1841105150

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 14, 2022 12:51 Inactive
@midavadim midavadim merged commit ef42217 into master Feb 14, 2022
@midavadim midavadim deleted the midavadim/841-source-github-validate-repo-name branch February 14, 2022 13:02
@midavadim midavadim temporarily deployed to more-secrets February 14, 2022 13:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Github - Validate repo name entered correctly in connector config
5 participants