-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source GitHub - added more meaningful error description for connector check #10211
🎉 Source GitHub - added more meaningful error description for connector check #10211
Conversation
/test connector=connectors/source-github
|
Codecov Report
@@ Coverage Diff @@
## master #10211 +/- ##
=========================================
Coverage ? 55.36%
=========================================
Files ? 3
Lines ? 466
Branches ? 0
=========================================
Hits ? 258
Misses ? 208
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please publish your changes
…e-github-validate-repo-name # Conflicts: # docs/integrations/sources/github.md
/publish connector=connectors/source-github
|
What
Errors in UI during connector check:
wrong repo name:
HTTPError('404 Client Error: Not Found for url: https://api.github.com/repos/airbytehq/airbyte3?per_page=100')"
wrong org name:
HTTPError('404 Client Error: Not Found for url: https://api.github.com/orgs/airbytehqBLA/repos?per_page=100')"
How
Added meaningful description for error during connector check
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here