Change jdbc sources to discover more than standard schemas #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Discussed offline. The desired behavior is as follows:
|
|
Then this PR should be ready to be merged whenever (or we can wait until we made the proper changes in the destinations first) |
cgardens
requested changes
Nov 23, 2020
There was a problem hiding this comment.
Awesome! Couple questions around how this new configuration is going to be set and how it is used in discoverInternal. Once we clear that up we can move forward.
I am fine merging once have the above figured out or waiting for changes to the destinations. We already have sources that emit streams with . in them so it is probably fine to do this before we change destinations as they already somewhat handle this case. we're not really making anything worse.
...c/main/resources/config/STANDARD_SOURCE_DEFINITION/435bb9a5-7887-4809-aa58-28c27df0d7ad.json
Show resolved
Hide resolved
...ectors/source-jdbc/src/main/java/io/airbyte/integrations/source/jdbc/AbstractJdbcSource.java
Outdated
Show resolved
Hide resolved
...ectors/source-jdbc/src/main/java/io/airbyte/integrations/source/jdbc/AbstractJdbcSource.java
Outdated
Show resolved
Hide resolved
...ectors/source-jdbc/src/main/java/io/airbyte/integrations/source/jdbc/AbstractJdbcSource.java
Show resolved
Hide resolved
...ectors/source-jdbc/src/main/java/io/airbyte/integrations/source/jdbc/AbstractJdbcSource.java
Outdated
Show resolved
Hide resolved
ChristopheDuong
force-pushed
the
chris/more-schemas
branch
from
be36796 to
c8b3baf
Compare
ChristopheDuong
commented
Nov 26, 2020
| @@ -2,6 +2,6 @@ | |||
| "destinationDefinitionId": "8be1cf83-fde1-477f-a4ad-318d23c9f3c6", | |||
| "name": "Local CSV", | |||
| "dockerRepository": "airbyte/destination-csv", | |||
| "dockerImageTag": "0.1.3", | |||
| "dockerImageTag": "0.1.4", | |||
There was a problem hiding this comment.
I forgot to publish this destination along with the others in #1060 so acceptance tests that are using this are not able to complete without the proper version
ChristopheDuong
requested review from
cgardens,
michel-tricot and
sherifnada
cgardens
requested changes
Nov 30, 2020
...ectors/source-jdbc/src/main/java/io/airbyte/integrations/source/jdbc/AbstractJdbcSource.java
Show resolved
Hide resolved
cgardens
approved these changes
Nov 30, 2020
davydov-d
added a commit
that referenced
this pull request
Nov 16, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 16, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 16, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 21, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 21, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 21, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 21, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 21, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 21, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 23, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 29, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 29, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 29, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 30, 2022
* #1038 source freshdesk - fix schema * #1038 source freshdesk: upd changelog * #1038 source freshdesk - remove temp file * #1038 source freshdesk: fix tests * #1038 source freshdesk: update expected records again * #1038 source freshdesk: rm unstable expected record * #1038 source freshdesk: edit another expected record * #1038 source freshdesk: edit another expected record * #1038 source freshdesk: fix expected records * #1038 source freshdesk: upd expected_records * #1038 source freshdesk: resolve dependency conflict * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In this thread from the #integration channel on slack:
https://airbytehq.slack.com/archives/C01AHCDHCKE/p1605795947045500
Sam Logan pointed out that we are not currently able to select tables from other schemas than the public one in the Postgres Source. Moreover, if possible, he would like to select multiple schemas at a time for that single postgres source.
How
In this PR, I was able to discover and list tables from multiples schemas.
Unfortunately, I am hitting a road block as the usual syntax for such JDBC is to use "schema.tablename" which is not a permitted AIrbyteStream Name (as reported in #925)
This makes sense because then the destination wouldn't be able to create such a table name (for example in BigQuery)
Alternative
my_schema_name_my_table_name(usable name for destination) but add additional special fields in the stream to specify which parts are actually for the original schema and which are for table names? (iemy_schema_name&my_table_name) such that the source is still able to decode the stream name into proper 'my_schema_name.my_table_name'